ipfix sample rate not being used about nfdump HOT 8 CLOSED

Implemented in master tree. Please verify.

from nfdump.

is there a trick to get master to compile on linux? ive tried centos6, centos7, and ubuntu 14.04 LTS. i get this error:

libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -ggdb -g -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -MT nffile.lo -MD -MP -MF .deps/nffile.Tpo -c nffile.c -fPIC -DPIC -o .libs/nffile.o
nffile.c: In function ‘NewFile’:
nffile.c:642: error: ‘for’ loop initial declarations are only allowed in C99 mode
nffile.c:642: note: use option -std=c99 or -std=gnu99 to compile your code
nffile.c: In function ‘DisposeFile’:
nffile.c:667: error: ‘for’ loop initial declarations are only allowed in C99 mode
make[3]: *** [nffile.lo] Error 1

surprisingly it compiled fine on macOS.

from nfdump.

seems that older gcc cannot compile master after 3bf7296
installed devtools7 on my centos machine and it compiled.

i am still verifying that the fix for ipfix sampling is working. will get back to you this week.

from nfdump.

Compile issue fixed. clang and gcc do not agree on local variable declarations.

from nfdump.

cool. the ipfix sampling does seem to be working. thanks!

from nfdump.

I've tested this fix with a Juniper MX104 exporting at 1:100 ratio using IPFIX template but have no sucess. Flows are still showing as "Unsampled" when nfdump'd using raw output.

pcap attached bellow. I think sampling information is available in packets 623 and 4410.

mx104_ipfix.zip

from nfdump.

Juniper does not export a sampling algorithm. nfdump required an algorithm in order to recognise sampling correctly.
I fixed that as the algorithm is not really used internally.

from nfdump.

I've just tested this fix. Sampling factor is properly being applied now. Thanks!

from nfdump.