GCC14 build failure about nfdump HOT 5 CLOSED

This is not an 1.7.4 issue, as that code did not change. It looks like you add your own build flags which add lots of other compiler options along with -Werror=format-security. This makes the potential warning of ‘const char **’ but argument is of type ‘char **’ to an error. You could leave that option out or reduce it to -Wformat-security.

from nfdump.

What rrdtool version have you installed?

from nfdump.

Fedora features rrdtool 1.8.0. But it can be built fine.
The issue, as you have mentioned, is in the build option(s) — and unfortunately I can't opt them out as a hardening requirement in the distro (probably, other distros will have the same issue).

from nfdump.

hmm .. but the released rrdtool-1.8.0 does not have the const char **) arguments. This was a change introduced in Dec 2023: oetiker/rrdtool-1.x#1242. This means Fedora uses the master repo for its package. But it also means that this breaks compatibility with the release version.
As long as there is no new release of rrdtool, I do not want to change the code, as this would break all other Linux distros, or *BSDs.
Therefore, you could patch nfdump-1.7.4 and add the const keyword to the rrd_arg array in nftrack_rrd.c as well as in profile.c

from nfdump.

I can confirm, it is a rather early change introduced as a patch to fix GCC14 compat in rrdtool: link.
I'll probably apply the same in devel branches, thanks for the hint.

from nfdump.