ph-7 / simple-java-calculator Goto Github PK

テスト

I wish to contribute a inverseSin function to the calculator

I found error when click 1+0=

The project was forked and imported with eclipse IDE, however at the time of compiling and executing the program it does not render properly, the buttons appear misaligned and do not execute their corresponding actions, perhaps it is due to the migration from eclipse IDE to NetBeans IDE .

Hello,
I appreciate your work,i really like your project.
I try to extend your code,so i add three new buttons.
Specifically i add x^y button,which calculates x(first number) power of y(second number).Second button is log10(x),which calculates the logarithm of a number x.Finally i add x% button,which calculates the percentage of the number x.
I also upload the files with changes,so you can check it.
I hope you find it helpful.

Friendly,
Donis Chantzaridis

simplejavacalculator.zip

On running the project on eclipse IDE , the above output is showing.

Good day sir. I am a graphic designer and i am interested in designing a logo for your good project. I will be doing it as a gift for free. I just need your permission first before I begin my design. Hoping for your positive feedback. Thanks

Suggestion for new feature

I noticed that the calculator does not offer the modulo operation (which returns the remainder during a division of two numbers).
So, I could add this specific feature.

There is a folder called private under the nbproject folder. This folder contains private information that is machine specific and not project specific.
According to the following link:
http://docs.oracle.com/cd/E50453_01/doc.80/e50452/create_japps.htm#NBDAG2974

If the project is checked out of a version control system, the build (or nbbuild), dist (or nbdist), and the nbproject/private folders should not be checked into that version control system. If the project is under the CVS, Subversion, or Mercurial version control systems, the appropriate "ignore" files are created or updated for these directories when the project is imported. Though nbproject/private should be ignored, nbproject should be checked into the version control system. nbproject contains project metadata that enables other users to open the project in NetBeans without having to import the project first.

Project: SimpleJavaCalculator
File Affected: Calculator.java

Description
With the intention of implementing SOLID principles in the code, there is a violation of the SRP within the class, to solve the following change was proposed where the mathematical operations will be performed in another class.

Also, to avoid OCP, classes were created with the mathematical operations to be performed, if you want to implement new functions, only the class with the new operation is created. The classes already defined are not modified.

To avoid problems with LSP, 2 clear interfaces were defined that will be implemented by the operations according to the amount of information they need.

Finally, to respect the DIP principle, the class depends on abstractions and not on defined implementations, avoiding problems in the code flow.

Additional Notes:
I have a branch where the mentioned changes were made, packages and other necessary classes were added to keep the project in SOLID design principles.

Project: SimpleJavaCalculator
File Affected: Calculator.java
Line Number: [Line number where the bug is found, for example: 57]
Severity: High

Description:
The PMD tool detected an issue in Calculator.java related to the incorrect use of the .equals() method for object comparison. Using == or != for object comparison can lead to unintended behaviors since it checks for reference equality rather than content equality. In Java, when comparing objects for equality in terms of their content, the .equals() method should be employed.

Output from PMD:

[WARNING] PMD violation detected. Rule:UseEqualsToCompareStrings Priority:3 .equals() should be used to compare object references. 

Suggested Fix:
Replace the == or != comparison of objects with the .equals() method for accurate content-based comparison. Ensure that the class has a properly overridden .equals() method if needed.

Steps to Reproduce:

1. Navigate to Calculator.java.
2. Go to the mentioned line number.
3. Observe the object comparison using == or !=.

Additional Notes:
This kind of bug can potentially lead to logical errors in the application. Even if the current implementation does not throw an error, it's a potential source of future bugs, especially if changes are made to the way objects are created or managed.