Especially now that WordPress has implemented them, what about adding the site icon as an avatar if no hcard/uphoto can be found?

Find a way to identify and merge the original reply and its POSSE copy. Check for duplicate text for comments on the same post, check for u-syndication....

Linkback Fix should be rerun on update comment by being added to the edit comment hook.

My reply to @snarfed's post is not showing the contents of my reply on his site, only that I "replied on gregorlove.com." We think this might be because my in-reply-to has a nested h-cite instead of a simple text string (or array of strings).

Reference: http://indiewebcamp.com/irc/2015-03-22#t1427041811926

The commit log shows the parser version dates from 2013. The commits on php-mf2 show there have been a lot of enhancements since then.

WordPress has a series of filters off its wp_notify_postauthor function to customize that presentation.

https://developer.wordpress.org/reference/functions/wp_notify_postauthor/#source-code

When I receive a notification of a comment generated through a combination of Bridgy and Semantic Linkbacks, it looks something like this...

Author: Bridgy Response (IP: 107.178.195.220, 220.195.178.107.gae.googleusercontent.com)
E-mail:
URL: https://brid-gy.appspot.com/like/facebook/100002356503167/858841630871046/10154036849115445
Whois: http://whois.arin.net/rest/ip/107.178.195.220
Comment:
This Article was mentioned on brid-gy.appspot.com

It should be trivial to use the same presentation logic to make the notification readable.

Originally suggested a Git Submodule to allow easy updating of the parser.

see: https://indiewebcamp.com/rsvp

To speed load, how about caching locally of avatar photos from external sites?

see https://github.com/pfefferle/wordpress-semantic-linkbacks/blob/master/semantic-linkbacks-microformats-handler.php#L310

http://indiewebcamp.com/irc/2016-04-25/line/1461626249171

Suggestion to send the prettified comment text to the Comment RSS Feed.

Since the last release, the notification mails sent by Wordpress are compelete messed up. As the blog admin, I get empty mails like this:

Ein neuer Kommentar zum Beitrag „“ wartet auf deine Freigabe

Autor: (IP: , )
E-Mail:
URL:
Kommentar:

while the post author gets mails that contain the entire article in the "Comment:" field ("Kommentar" in the above quote). With the previous version, notifications worked fine.

Due to the bug fixed in 4.2(https://core.trac.wordpress.org/ticket/30627), and the pre_get_avatar_data hook, the current version of Semantic Linkbacks should have a minimum version of WordPress 4.2.

Change h-as-* to u-*...

Example: h-as-reply would turn to u-reply.

http://indiewebcamp.com/irc/2015-06-09/line/1433880387532

Some people do not have a Twitter, Facebook, etc icon. Is there a way to identify this and remove the image entirely?

(maybe related to #54)

Hi,

I'd love to get a hint on where to look for the right place where the plugin's code decides which semantic_linkbacks_type is stored in wp_commentmeta table. It seems that in my install it'll fallback to the generic "mention" when it recives a webmention from brid.gy.
Here's a log from brid.gy:

2016-05-26 10:07:08.268750 D Params: NestedMultiDict([('response_key', u'aglzfmJy...')])
2016-05-26 10:07:08.523300 I Source: webrocker (Twitter) webrocker, http://brid-gy.appspot.com/twitter/webrocker
2016-05-26 10:07:08.523920 I Created by this poll: http://brid-gy.appspot.com/log?start_time=1464257167&key=aglzfmJyaWQtZ3lyFgsSB1R3aXR0ZXIiCXdlYnJvY2tlcgw
2016-05-26 10:07:08.524730 I Starting Response like tag:twitter.com,2013:735747260508602368_favorited_by_205651658 https://twitter.com/webrocker/status/735747260508602368#favorited-by-205651658
2016-05-26 10:07:08.556630 I Webmention from https://brid-gy.appspot.com/like/twitter/webrocker/735747260508602368/205651658 to https://www.webrocker.de/?p=24638
2016-05-26 10:07:08.616720 I Using cached webmention endpoint u'W https webrocker.de': https://www.webrocker.de/blog/?webmention=endpoint
2016-05-26 10:07:08.617180 I Sending...
2016-05-26 10:07:11.340670 I Sent! {'body': u'array(19) {\n ["comment_ID"]=>\n string(4) "7788"\n ["comment_post_ID"]=>\n string(5) "24638"\n ["comment_author"]=>\n string(13) "Holger Bartel"\n ["comment_author_email"]=>\n string(0) ""\n ["comment_author_url"]=>\n string(79) "https://brid-gy.appspot.com/like/twitter/webrocker/735747260508602368/205651658"\n ["comment_author_IP"]=>\n string(15) "107.178.195.139"\n ["comment_date"]=>\n string(19) "2016-05-26 12:07:10"\n ["comment_date_gmt"]=>\n string(19) "2016-05-26 10:07:10"\n ["comment_content"]=>\n string(158) "This Article was mentioned on <a href="https://brid-gy.appspot.com/like/twitter/webrocker/735747260508602368/205651658" rel="nofollow">brid-gy.appspot.com</a>"\n ["comment_karma"]=>\n string(1) "0"\n ["comment_approved"]=>\n string(1) "0"\n ["comment_agent"]=>\n string(102) "Bridgy (https://brid.gy/about) AppEngine-Google; (+http://code.google.com/appengine; appid: s~brid-gy)"\n ["comment_type"]=>\n string(10) "webmention"\n ["comment_parent"]=>\n string(1) "0"\n ["user_id"]=>\n string(1) "0"\n ["children"]=>\n NULL\n ["populated_children"]=>\n bool(false)\n ["post_fields"]=>\n array(21) {\n [0]=>\n string(11) "post_author"\n [1]=>\n string(9) "post_date"\n [2]=>\n string(13) "post_date_gmt"\n [3]=>\n string(12) "post_content"\n [4]=>\n string(10) "post_title"\n [5]=>\n string(12) "post_excerpt"\n [6]=>\n string(11) "post_status"\n [7]=>\n string(14) "comment_status"\n [8]=>\n string(11) "ping_status"\n [9]=>\n string(9) "post_name"\n [10]=>\n string(7) "to_ping"\n [11]=>\n string(6) "pinged"\n [12]=>\n string(13) "post_modified"\n [13]=>\n string(17) "post_modified_gmt"\n [14]=>\n string(21) "post_content_filtered"\n [15]=>\n string(11) "post_parent"\n [16]=>\n string(4) "guid"\n [17]=>\n string(10) "menu_order"\n [18]=>\n string(9) "post_type"\n [19]=>\n string(14) "post_mime_type"\n [20]=>\n string(13) "comment_count"\n }\n ["comment_subscribe"]=>\n string(1) "N"\n}\nhttps://twitter.com/webrocker/status/735747260508602368#favorited-by-205651658', 'request': u'POST https://www.webrocker.de/blog/?webmention=endpoint (with source=https://brid-gy.appspot.com/like/twitter/webrocker/735747260508602368/205651658, target=https://www.webrocker.de/?p=24638)', 'http_status': 200}
2016-05-26 10:07:11.434250 I Setting last_webmention_sent

The way I see this, there are two possible indicators that this is a "like":
The webmention source contains /like/ in the URL, or the fragment-Identifier "#favorited-by-205651658"

I'm looking through the sematic-linkbacks.php source, but I don't see/understand where the comment meta data for semantic_linkbacks_type first gets set - all I see are the instances where checks run against this meta data (and a fallback to "mention" inside the comment_text_excerpt function).

When I receive the mention from the log above, it gets stored as "mention". When I change this manually in the database to "like", the display is fine. But somehow the Twitter "likes" via brid.gy end up as "mention".

Last comment stored and displayes as 'mention':

Last comment stored and displayes as 'like', manually changed in db:

Is the semantic_linkbacks_commentdatafilter (line 141) the right place to hook into for that?
I'm also wondering where the commentdata['_type'] (line 149) is set, if any ?

So first and foremost thanks for the plugin and then thanks in advance for any hints :-)
Tom

Instead of checking that the in-reply-to links link to the exact permalink of the post the comment is on, I propose instead checking if the post_ID we get from url_to_postid on the in-reply-to link matches the local post_ID -- this would allow for more flexibility for the format of the link on the remote (eg, both ?p= and rewrite forms would work).

Tangentially related to #75, but it appears that "mention", "like", and "reply" are supported natively, but not "bookmark"?

So for example, the comment display will default to X "mentioned" post or Y "liked" post on service z, But would/could it say X "bookmarked" this post, particularly if the originating post had u-bookmark-of? I would presume that it would potentially have semantic_linkbacks_type be "bookmark" rather than "mention" or "reply" perhaps? And then that this could potentially be edited if the sending post wasn't carrying the correct mf2 class?

Example: http://boffosocko.com/2017/01/27/my-reply-to-micro-blog-project-surges-past-65k-on-kickstarter-gains-backing-from-dreamhost-wordpress-tavern/#comment-33624 which is a bookmark of the post technically rather than a simple mention, so it would be nice if it output "X bookmarked this post" in the comments in a parallel way as mentions and likes.

The question is is this a desirable default behavior?

Proposing we include a WordPress import file that will add a post with the various types to add to the database to test styling.

I wanted to open the topic of storing additional data from the source URL as comment meta.

Things such as a summary, site name, language(it's in the pingback spec), featured image(if we can find one)... not sure what else might be relevant.

currently, mentions are rendered as:

X mentioned this post on [domain].

...which is fine, but if the mention post is a note and/or its content text is short enough - say, < 140 chars :P - it'd be nice to show the content text inline.

motivated by snarfed/bridgy#456, which now searches twitter and google+ for other people's posts that link to your site and sending them as mentions.

@acegiak has done awesome work implementing the salmention prototype in the upstream repo. it sounds like it might not be polished enough to merge in here, but i'd love to see that happen eventually. pretty please with sugar on top!

Suggesting that the plugin not enhance trackbacks by default due to lack of source validation.

The excerpt uses Post Format. Which means if you don't use Post Format, all excerpts will use "Article"

I would want to use Post Kinds, but there is no easy way to change just the format.

The pingback and trackback specifications do not allow for updates. The code specifically returns an error on duplicate pings.

The enhancement code should therefore only be run on the creation of a new comment or the updating of a webmention type only.

Thoughts?

To address the existing linkbacks pre-plugin without a batch function, how about running it the following hook?

https://developer.wordpress.org/reference/hooks/edit_comment/ - Run when comment is updated

Include custom comment walker and linkback display functions in plugin package that can better display these enhancements.

The changes to the get_avatar function in 4.1-4.2 allow for a better way to override the behavior of get_avatar with new filters/hooks.

I'm going to see about submitting a pull request to alter this to keep up with same.

This should use comment_ID, which is passed to it...and it is now throwing an error in my tests.

See aaronpk/webmention.io#39 (comment). I think these thoughts on text are worth noting.

Thinking of writing this, but wanted some thoughts on it. What about adding to the comment_class filter to add css classes to the displayed comments regardless of theme?

Does this make sense?

Comment notification emails, in Version 4.4, will be firing from hook comment_post. To account for the emails going out before the linkback can be enhanced. suggesting this be set to higher than default.

4.4 Commit - https://core.trac.wordpress.org/changeset/34106

hi pfefferle,

May I ask why have you added the type as comment meta instead of using the comment_type field for this?

To make it easier to develop and improve, suggesting we switch over to php-comment to allow for wider development of features.

https://github.com/indieweb/php-comments

I just noticed this changed in 4.4.

https://developer.wordpress.org/reference/functions/wp_insert_comment/

If comment meta is provided in an array to wp_insert_comment, it will store it. I had asked for something like this during the 4.4 cycle. Not sure how it slipped past me.

But this means we might be able to fix the problem discussed in #39 by splitting the work to be done. Opening this issue, though I might explore this myself.

Inspired by Indieweb chat comment...
http://indiewebcamp.com/irc/2014-11-06/line/1415329191652

The Webmention plugin already intercepts trackbacks/pingbacks to appear identically to webmentions.

An option should be added to convert existing pingbacks/trackbacks already in the database. This would allow for backward compatibility.

unicode chars in content like reacji have worked for me before, e.g. https://snarfed.org/2016-08-27_18491#comment-2600432 , but they're now rendered as This Article was mentioned on brid-gy.appspot.com, e.g. https://snarfed.org/2016-11-09_22762#comment-2601735 .

i've tried a few different versions, including current stable release and git head here.

i've tracked it down to this wp_update_comment call. $commentdata['comment_content'] has the right unicode content, e.g. 😢, but the wp_update_comment call returns 0 instead of 1, which the docs say means it failed.

i can post comments manually with that same character, and they render ok, so i don't think it's wordpress's or mysql's fault. i've reproduced on wordpress 4.6.1 on both freebsd (mysql 14.14 5.6.23) and mac os x (mysql 14.14 5.7.14).

thanks in advance!

Add these fields to the edit comment form in the admin. Partially this is also to allow viewing of this data in the admin.

Add data-url support for services that are changing their avatar-urls, like twitter.

http://indiewebcamp.com/tag

http://indiewebcamp.com/irc/2014-11-21/line/1416627131248

The suggestion for new markup, u-tag-of, was made. Proposing this be added as a comment type. This would indicate a post that is tagging another post. Example: Alice tagged this post as "indiewebcamp"

In addition to that showing up as a comment, hooks could be added to automatically, if the comment is approved, add the tag to the list of post tags.

If the linkback is to the same domain/site, identify this with a change in text.

For example, substitute 'this site' for 'on example.com'.

https://indieweb.org/reacji#How_to

Bridgy is now displaying Facebook Reactions. Since they are coded as in-reply-to, the plugin displays them as a reply, which means comment form. I'd rather have them remain as webmention types, and allow them to be grouped together.

Suggesting, even though it isn't required, that the plugin register its meta keys using the adjustments made in 4.6 and check before registration that it isn't already registered.

The advantage of this is to allow for sanitization and validation of meta keys as well as allowing other plugins to check that they are reserved keys.

https://developer.wordpress.org/reference/functions/register_meta/

https://developer.wordpress.org/reference/functions/get_registered_meta_keys/

i recently ran into this when all of the bridgy webmentions on a post of mine showed up as plain mentions instead of favorites, retweets, etc: https://snarfed.org/2015-03-07_huffduff-video

in this specific case, the bridgy source mf2 for each response has both a mention link and a like/repost/etc link, e.g. https://brid-gy.appspot.com/repost/twitter/schnarfed/574460993398427649/574962900458205184 :

<div class="e-content">
RT <a href="https://twitter.com/schnarfed">@schnarfed</a>: huffduff-video lets you send @Huffduffer the audio from videos on YouTube, Vimeo, and more! snarfed.org/2015-03-07_huf… huffduff-video.snarfed.org
<a class="u-mention" href="https://snarfed.org/2015-03-07_huffduff-video"></a>
</div>
<a class="u-repost u-repost-of" href="https://twitter.com/schnarfed/status/574460993398427649"></a>

when the plugin handles this mf2, it sees the u-mention link first, so it stores semantic_linkbacks_type = mention in wp_commentmeta and the wordpress comment gets rendered as a mention. if i remove the mention link and resend the webmention, it sees the u-repost-of link and correctly stores semantic_linkbacks_type = repost.

it should probably instead look at all of the links to target in the mf2, and if any of them are semantic, those should be prioritized over mention, right?

thanks in advance! cc @dshanske

Example: http://david.shanske.com/notes/2014/06/03/view/

The Mentions are this were sent as Facebook likes.

However, on this previous post, a Facebook like was classified correctly

http://david.shanske.com/notes/2014/05/29/going-somewhere-scenic/

The only difference I see is the comment text. On the 5/29 post, it was Liked this Aside. On 6/03, it was mentioned this image.

Here is one of the falsely classified from Bridgy
https://brid-gy.appspot.com/like/facebook/100002356503167/650586338363244/504759760

Since the filters are part of the SemanticLinkbacksPlugin class, I can't find a way to easily remove them from another plugin. The code suggested for removing the functions from comment_text does not work.

Found this suggestion.

http://hardcorewp.com/2012/enabling-action-and-filter-hook-removal-from-class-based-wordpress-plugins/

See http://weber.teamchad.org/2015/12/christmas-greetings-and-thanks/#comment-6920 and https://brid.gy/log?start_time=1450900642&key=aglzfmJyaWQtZ3lySwsSCFJlc3BvbnNlIj10YWc6dHdpdHRlci5jb20sMjAxMzo2Nzk3NDg2Mjg2MTc5MDAwMzJfZmF2b3JpdGVkX2J5XzE2Njg1MDE1DA

The get_avatar function returns class photo, it should also return class u-photo for mf2 compliance.

Plugin needs some standard functions to be called by other plugins, themes. For example....

get_webmention_type_count($post_id, $type) - Return the count for a type of webmention for the current or specific post