Giter Club home page Giter Club logo

Comments (7)

Enforcer avatar Enforcer commented on May 18, 2024

Hi, I am table to take a look at this. Is there anything I should know before dealing with this issue?

from pext.

TheLastProject avatar TheLastProject commented on May 18, 2024

The main issue is that everything in the main file, https://github.com/Pext/Pext/blob/master/pext/pext.py, is very tangled up with the rather huge Window class at https://github.com/Pext/Pext/blob/master/pext/pext.py#L1689-L2248. You will see functions in every class starting with the word "bind" which is generally where things are coupled to the Window class (either there or the constructor already). So it is likely you'll have to figure out how to decouple some things with the Window class so they can be tested without actually opening a window. This issue is just as much about cleaning the code so it becomes more testable than writing an actual issue test and probably one of the hardest issues (unless you're good at refactoring).

from pext.

Enforcer avatar Enforcer commented on May 18, 2024

I see, I think the task is clear for now. Please assign me to this issue

from pext.

TheLastProject avatar TheLastProject commented on May 18, 2024

Unfortunately, I can't seem to assign you because you haven't collaborated before and aren't in a team: https://help.github.com/articles/assigning-issues-and-pull-requests-to-other-github-users/. I'm inviting you to an "Hacktoberfest" team to try to work around this weird design, will assign you then.

from pext.

TheLastProject avatar TheLastProject commented on May 18, 2024

Okay, assigned :)

from pext.

TheLastProject avatar TheLastProject commented on May 18, 2024

Hey, it's been 2 weeks, just poking to ask if you managed to make any progress and what your plan for this is :)

from pext.

TheLastProject avatar TheLastProject commented on May 18, 2024

With @ata2001's recent contributions, I consider this issue good to close. Of course, more tests are a great idea, but this is a great start, and we have a test now :)

from pext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.