Comments (7)
Hi, I am table to take a look at this. Is there anything I should know before dealing with this issue?
from pext.
The main issue is that everything in the main file, https://github.com/Pext/Pext/blob/master/pext/pext.py, is very tangled up with the rather huge Window class at https://github.com/Pext/Pext/blob/master/pext/pext.py#L1689-L2248. You will see functions in every class starting with the word "bind" which is generally where things are coupled to the Window class (either there or the constructor already). So it is likely you'll have to figure out how to decouple some things with the Window class so they can be tested without actually opening a window. This issue is just as much about cleaning the code so it becomes more testable than writing an actual issue test and probably one of the hardest issues (unless you're good at refactoring).
from pext.
I see, I think the task is clear for now. Please assign me to this issue
from pext.
Unfortunately, I can't seem to assign you because you haven't collaborated before and aren't in a team: https://help.github.com/articles/assigning-issues-and-pull-requests-to-other-github-users/. I'm inviting you to an "Hacktoberfest" team to try to work around this weird design, will assign you then.
from pext.
Okay, assigned :)
from pext.
Hey, it's been 2 weeks, just poking to ask if you managed to make any progress and what your plan for this is :)
from pext.
With @ata2001's recent contributions, I consider this issue good to close. Of course, more tests are a great idea, but this is a great start, and we have a test now :)
from pext.
Related Issues (20)
- Hitting "Update and reload" on a module in use freezes Pext until the update completes HOT 1
- AppVeyor build broken HOT 1
- password store module not installable HOT 2
- Escape to minimize doesn't work when focused module is updating HOT 1
- Closing module during module update causes exception when update completes and Pext attempts to reload it
- Modules failing to install on Debian Buster HOT 2
- Dependabot couldn't authenticate with https://pypi.python.org/simple/
- Launcher icon does not work
- newer version 0.6 ? HOT 1
- execution on Linux fails HOT 6
- Upgrade Python used HOT 9
- Copy to clipboard doesn't work on Wayland
- AppImage build broken
- macOS build broken HOT 2
- Module updater can offer a non-existant update
- Pext is not working in Arch Linux installed from AUR. HOT 7
- Pext-git is not working in Arch Linux installed from AUR. HOT 2
- Upgrade to Qt6 HOT 8
- Can't install modules on macOS
- Build system generates wrong version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pext.