Giter Club home page Giter Club logo

Comments (8)

TheLastProject avatar TheLastProject commented on June 7, 2024 1

Sure, let's hope it's easy instead of hard :)

from pext.

airvzxf avatar airvzxf commented on June 7, 2024

I can work on this, could you please assign to me?

from pext.

airvzxf avatar airvzxf commented on June 7, 2024

It needs many changes in the code because QT6 changes a lot regarding QT5.

Added screenshots about these two errors:

  • The first one I solved, removing the version of import QtQuick.Controls or adding the last version import QtQuick.Controls 6.4
    • 01-QtQuick Controls_1 4-Error
  • The second, I can't resolve yet, but looks like it requires changes in the code. I didn't find the Extras and Styles in QT6. You have more experience in this topic, what do you think?
    • 02-QtQuick-Errors
  • If I removed all the versions, the problem still there because in QT they are not existing.
    • 03-QtQuick-Errors

References:

from pext.

TheLastProject avatar TheLastProject commented on June 7, 2024

Looking at dd11097, QtQuick.Extras was included for the flat theme.

And QtQuick.Controls.Styles was added in a commit that doesn't describe it: 3fe352c

I think removing both imports may have stuff just work fine. At worst, it may misbehave during the app.setStyle calls in pext/__main__.py, those might need to be removed. As far as I know those were barely ever used ever, only called if someone started Pext specifically with the --style argument. Removing support for that if it's difficult to keep sounds completely fine to me too.

from pext.

airvzxf avatar airvzxf commented on June 7, 2024

Well, I tried, and it needs to refactor and replacement because QT6 has huge changed related to QT5. Same reference Differences with Qt Quick Controls 1.

I made some changes, and it is running, but the menus are not working. Other stuff should not work. Since, I am not expert on QT, and I don't pretend to learn all QT in deep, I need your help with your experience and expertise.

I was tentative to add a summary with the changes, but it's better to see in a comparative using the GitHub tools.
https://github.com/Pext/Pext/compare/master...airvzxf:Pext:upgrade-to-qt6?expand=1

You can clone my repo (airvzxf/Pext) and checkout the branch upgrade-to-qt6. Please don't hesitate to modify and push changes.

Visible error when run in my local, any menu option is working:

04-QtQuick-Frankinstein

from pext.

TheLastProject avatar TheLastProject commented on June 7, 2024

Hmm, interesting,

All I can tell is that the "Component is not ready" means that there was some QML error (it's awful to debug, I have no clue how to fix it when it occurs, I always just tried random stuff until it works). The property errors make me wonder if the MenuItem and TabBar QML6 types maybe have these functions under other names?

from pext.

TheLastProject avatar TheLastProject commented on June 7, 2024

By the way, I don't know how you're doing on Hacktoberfest contributions, but if you're looking for more to do quickly then #457 is probably a good place to start because you almost already did that (and this Qt6 thing will probably take longer)

from pext.

airvzxf avatar airvzxf commented on June 7, 2024

Totally, agree. I'll pause this work and contribute to the other.

from pext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.