PID cannot be instantiated about bdsim HOT 6 CLOSED

Ok, thanks. I have a fix for another issue involving 2 signals added together not working when going into a LTI_SS block. Would you be interested in a pull request fix? -Dan On Jul 6, 2023, at 12:23 AM, Peter Corke ***@***.******@***.***>> wrote: Thanks for your interest and post. PID is a late addition to bdsim and not fully tested, sorry. Let me have a look over the weekend and get back to you. Your test example will be helpful. — Reply to this email directly, view it on GitHub<#18 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEAHRTYGFUGYH5FLOTAKJMTXOY4UVANCNFSM6AAAAAAZ4WDOCI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

Sure.  The issue is with the SUM or LTI_SS block?  The former I would have thought/hoped was pretty solid.PeterSent from my iPadOn 6 Jul 2023, at 10:22 pm, dgrunberg ***@***.***> wrote: Ok, thanks. I have a fix for another issue involving 2 signals added together not working when going into a LTI_SS block. Would you be interested in a pull request fix?

Actually the issue is with the INTEGRATOR (I thought it was the SUM), I will post an issue, and then a fix. -Dan On 7/6/23 5:51 PM, Peter Corke wrote: Sure. The issue is with the SUM or LTI_SS block? The former I would have thought/hoped was pretty solid.PeterSent from my iPadOn 6 Jul 2023, at 10:22 pm, dgrunberg ***@***.***> wrote: Ok, thanks. I have a fix for another issue involving 2 signals added together not working when going into a LTI_SS block. Would you be interested in a pull request fix?

Yes, seems to work now, thanks! Although it took some head scratching to figure out that the default is I_band=0.0, which means the INTEGRATOR never works. I did a pull request for that change in case you want it. Thanks, Dan On 7/9/23 1:05 AM, Peter Corke wrote: Hi @dgrunberg<https://github.com/dgrunberg>, thanks again for your interest in this. Looking at the PID code I confess it's a mess and I can't even recall where I was going with this... I've rewritten it, it's simpler now, and it now implements all the passed arguments. It's checked in on master branch, along with examples/pid.py. As per the original docstrings, but not the initial implementation, this block has two inputs: plant output, plant reference output. I'd be grateful if you could have a play and let me know how it goes. — Reply to this email directly, view it on GitHub<#18 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEAHRT6DOG63GBM7P6J657TXPI3YTANCNFSM6AAAAAAZ4WDOCI>. You are receiving this because you were mentioned.Message ID: ***@***.***>