persata / plaits Goto Github PK

The validator attempts to check the MIME type even if nothing was uploaded. Add a check first before validating.

Using _.merge is modifying the res.locals object passed around by Express which causes issues with data being duplicated and overwritten.

Use _.assign instead to create a new object that won't modify the res.locals object.

poopie

The line:

if (this.labels && this.labels[field] !== null) {

is too strict a comparison, if the value is not present the actual value is undefined, not null.

Either change it to be 'truthy' (i.e. if (this.labels && this.labels[field]) {) or check against undefined.

Fix the check to check for null and not just 'undefined'.

Since object keys for the model values will be strings, the use of _.contains is strict checking the values which can mean checking an int against a string, which will return false.

The model values should be coerced to strings before comparison to ensure an accurate check.