Giter Club home page Giter Club logo

peopledatalabs-ruby's People

Contributors

jamesbaez avatar vvillait88 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

peopledatalabs-ruby's Issues

Patch 2.3.1 should be a major version bump (3.x)

Describe the bug
A recent patch was released labeled 2.3.1. As a patch level update, it should only include backward compatible bug fixes. However, this change includes an API change that breaks backward compatibility.

To Reproduce
Steps to reproduce the behavior:

     Failure/Error:
       response = Peopledatalabs::Autocomplete.retrieve(
         field: type,
         text: name,
         pretty: true,
         titlecase: true,
         beta: true
       ).deep_symbolize_keys

     ArgumentError:
       Invalid keyword arguments provided: beta

Expected behavior
Either:

  1. Maintain backward compatibility and print a warning if a deprecated param is used
  2. Update the major version of the library

Additional context
This is the commit that broke things: 0b461f2

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.