penneo / sdk-js Goto Github PK

createRequest function is undefined, it should be changed to the new this._createRequest

The standard among all other widely used dependencies is to include object-assign@^3.0.0, this creates a mismatching in version with the penneo-react application

The request handler should return a promise with the data in JSON format and the raw response object for other purposes.

The repository should be hooked up with travis. Even thought there aren't any tests at the moment, we need to make sure that the sdk compiles i.e.

npm run compile

The npm request library doesn't support IE8 and IE9, and it's what drives the SDK API Connector,
therefore a more compatible solution is required.

This makes applications don't load at all on IE9 and below, however, this might not be the only source of the problem. Since any other Ajax libraries the application is using besides the SDK might also cause the same scenario.

Further Reading:
http://stackoverflow.com/questions/19486597/formdata-is-undefined-in-ie-only
http://stackoverflow.com/questions/15475215/formdata-in-ie8-9

The compiled javascript sdk must be available after npm install, and the compiled version shouldn't be on source control.

The sdk should be compiled on the npm postinstall event.

main.js is exporting delete as connector.delete_, connector is exporting delete without the underscore suffix, therefore it's undefined

Errors on ES5 Environments (Gulp, Examples, Tests) are not being linted properly.

status is mapped to an undefined value in the request response.