pelican-plugins / linkclass Goto Github PK

This bug has been mentioned by GalaxyMaster in issue #32 : “the documented configuration does not match (and does not work) with the plugin. It requires three arguments instead of two in each tupple.”

This must be fixed.

Due to Python-Markdown/markdown@d18c3d0#diff-797c6da32780122232df19c7a2e709ebL341, the classes LinkPattern and ReferencePattern are no longer found and building the pelican site fails.

The new classes are now called LinkInlineProcessor and ReferenceInlineProcessor, and their handleMatch() method requires one additional argument.

This issue tracks the conversion of Link Class to a namespace plugin.

• convert to namespace plugin filesystem layout
• ensure existing test suite passes
• apply community code style standards
• add CI/CD configuration
• release new version to PyPI

Currently, the logic is purely based on whether the link has "https?://" as the string prefix for href. However, there are quite a few sites that use SITEURL Pelican setting to define the full URL for the generated internal links (this is mostly needed to support things like the sitemap plugin and others). When SITEURL is defined, this plugin would mark all links as external, which kind of renders it useless in these configurations.

For example, this markdown:

This is an [external link][my_url].

[my_url]: https://github.com/rlaboiss/pelican-linkclass/

The URL is external, but it doesn't get tagged as such.

Hi all,

I am on Ubuntu 22.04 with Python 3.10 and Pip 24.0 and I have installed pelican-linkclass (python3 -m pip install --user pelican-linkclass) but it is not importable.

In an interpreter, this causes an ImportError:

from pelican.plugins import linkclass

whereas it works for the plugin search for example.

The distribution info of the plugin is sitting in ~/.local/lib/python3.10/site-packages with name pelican_linkclass-2.1.3.dist-info alongside other namespace plugins such as search and similar-posts which can be imported normally.
However, contrary to these other plugins, it is not present in the subdirectory pelican/plugins/. Accordingly, when running pelican -D, we see that it does not discover it in the namespace plugins.

What's causing this? One difference I see is that packaging was done with pdm for linkclass, whereas other plugins were packaged with poetry.

At the moment I have to clone this repository and manually copy the proper folder into the pelican installation to make it work.

Thanks a lot for your help.

Hi! What do you think about making this plugin available through PyPI?

Or, if you don't want to, are you ok with me publishing it?