pcrompton / baseballstats Goto Github PK

In FormatGames.py (seventh commit), class Game, function replaceColumn, line 66:

array = numpy.insert(array, [col], List, 1)

It seems that certain components of "List" are getting cut off in this step, messing everything else up. Run TestListsOfGames.py and choose function "players". Choose either of the lists and in several of the failures it should be apparent that the play description is cut off (the other issue causing failures has to do with players on the same team with the same last name, which I have not gotten around to fixing yet). I have test code currently commented out in replaceColumn which led me to line 66. My conclusion is that it must be a problem with the method numpy.insert.

Hi Aaron,

I'm starting to get the hang of how this works. I probably have a ridiculous amount of commits right now, but at least I know how to do it!

I revised the code in a few ways today.

1. I split up the "moveBaserunners" function to a function for each base
2. I added a function (lookUpColumns) that allows the user to look up any and as many columns as they may wish for comparison
3. I wrote a new function (writeFile) and call it towards the end of formatBaserunners which writes a new csv file replacing the old "RoB" with the new "RoB."

I think the next part of my project is to clean up and revise what I have right now so that it's easy to work with. There are a few functions that may not belong here. What kind of suggestions might you have?