Giter Club home page Giter Club logo

youtubeautotranslatecanceler's People

Contributors

icetdrinker avatar knoxfighter avatar natoboram avatar pcouy avatar seneral avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

youtubeautotranslatecanceler's Issues

Project is missing a license

It could be that I just overlooked it, but it seems to me as if this project currently has no license. This theoretically makes it illegal for everyone except the author to do almost anything with this script—including simply using it as it’s intended. So please add a license to this project. See here for more info on this issue.

Playlist titles are replaced by titles of their first videos

See title. When, for example, viewing a user's playlists page, the script acts on the previews of playlists, fetching the original name of the first video and replacing the playlist's title with it.
Here's a screenshot:
изображение
Left is without the script, after is with it.

I solved this issue for myself by simply preventing the script from working on the playlists page:
// @exclude https://www.youtube.com/user/*/playlists*

However, this is a your-mileage-may-wary solution - some users might prefer the current behavior, as the first video's title allows to a limited extent infering the nature of the playlist even without seeing the name. Ideally, the script should recognize playlists and fetch their names (if the API allows that), rather than the first videos. Either way, it's not a high-priority issue.

YouTube Auto Play support

Information of the previous video is carried over when using Youtube auto play, which will result in descriptions from the previous videos still being displayed for all following ones.

There are two problems with this: Not only doesn't the script recognise the new video and replace the video description, but youtube itself also doesn't replace the modified description at all...

That last one is worrying me tbh, it seems Youtube notices changes to the description and explicitly does not overwrite them.

Obvious solution would be to detect a video change (easiest through URL), discard all caches and reevaluate the whole page.

Also worthy of note is that it seems that ONLY the description is affected, nothing else. No clue why though.

Description Accumulates over time

For some reason, the translated desciptions of past videos (during youtube auto-play) are carried over and the newly fetched description get's appended. Should be an easy fix, will look into it right now.

var api_key_awaited gets defined twice

    var NO_API_KEY = false;
    var api_key_awaited = await GM.getValue("api_key");  // HERE
    if(api_key_awaited === undefined || api_key_awaited === null || api_key_awaited === ""){
        await GM.setValue("api_key", prompt("Enter your API key. Go to https://developers.google.com/youtube/v3/getting-started to know how to obtain an API key, then go to https://console.developers.google.com/apis/api/youtube.googleapis.com/ in order to enable Youtube Data API for your key."));
    }
  
    var api_key_awaited = await GM.getValue("api_key");  // AND HERE
    if(api_key_awaited === undefined || api_key_awaited === null || api_key_awaited === ""){
        NO_API_KEY = true; // Resets after page reload, still allows local title to be replaced
        console.log("NO API KEY PRESENT");
    }

Wrong titles on some videos

Hi there,

Sometimes it happens that some videos have the wrong title and thumbnail.
For example: It has the title of Radio Ga Ga by Queen, but it has the thumbnail of one of George Michael's songs and says it's on George Michael's channel.

Can you fix it?

Timestamps in video description

Timestamps are a kind of link to a specific position in a video, format "00:00", which currently will only be displayed as plain text and cannot be clicked.

Do not work with Classic interface

Hi,
The script do not work if using the classic interface of Youtube.

Failed to find main video description! userscript.html:137:42
Checking main video and 0 video titles! userscript.html:105:21
Failed to find main video description! userscript.html:137:42
Checking main video and 0 video titles! userscript.html:105:21
Failed to find main video description! userscript.html:137:42
Checking main video and 0 video titles! userscript.html:105:21

Using the "modern" interface, the script works correctly.

Tested with Firefox nightly.

Plugin doesn't work when a video appears on the main page

So in general, the plugin works great but it doesn't seem to take effect for videos that appear on the main page of Youtube. I had a case where a video was recommended to me on the main page with its title in English but when I clicked it, the title under the video was in Japanese (since the plugin had re-translated it to the original).

YouTube Mixes

image

The tool shouldn't edit the titles of the mixes. Right now, I can't recognize my mix from other songs' mixes.

Massive increase in the number of API queries after updating to 0.2

Soon after updating to 0.2, the script started asking me for a new key every time I loaded a youtube video. I quickly found out that the cause of that was that the API requests weren't working, and the cause of that was that the Google API daily quota of 10000 queries was exhausted. Before, the script rarely used more than 1000 requests a day, meaning that the number of queries was increased more than tenfold by the update.

Don't work... what did i do wrong?

Hi,
[removed earlier comment because i didn't see what it does and what it does not do, see under]

Edit: I think i understand: this only change the auto-translate title in a "video" page, but not in the general menu (youtubers' channels or main youtube page).

I get it. It is not what I expected because for me, when I'm in a video page, i don't pay attention anymore to the title (maybe to the description still!); but when i'm reading videos title in a youtuber channel main page, there i pay a really great attention to titles, and thus skip "auto translated" titles (and thus, learned about this script preventing that... but this script doesn't do what I want.)

Could that be changed/updated to put the change there too?

Edit: i'm sorry, i'm really new on this github and i'm not sure if it is a "issue" or "pull request"... sorry.

Livestream video description

Seems there is a problem with the video description on livestreams. It seems to be duplicated a lot, when I noticed it it was already 50-100 times the original description after an hour or so. Observed page change detections occasionally, maybe related. Youtube probably adds the description again itself, so might need to cache the assigned description and reassign it when it changes, since youtube can't remove custom modified stuff (like our description) and thus keeps appending it...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.