pceres / lint_php Goto Github PK

I'm not sure if this issue is really a "issue", or if it's just my misconception of cyclomatic complexity, but:

• if the if + else if tokens are sufficient to get full branch coverage (i.e.: else worth 0), shouldn't the same logic be applied to the default case of switch statements, instead of valuing it as 1?
• if I have a block of code that looks like this:

try
{
    // something
}

catch (\PDOException $e)
{
    // foo
}

catch (\Exception $e)
{
    // bar
}

Shouldn't try be worth 0 and each catch block be worth 1?

• in PHP 5.5+: I don't think the new finally (http://php.net/manual/en/language.exceptions.php) block should be counted, but should it?
• in PHP 5.3+: what about the goto keywords or it's labels?

No warning message when a variable is output without setting it inside the function

es.:
function $output_var = foo()
{
disp('hello');
}