pbarrio / vocabularyquiz Goto Github PK

Currently the test picks up the words that have the worst (passed-failed) number. This is good to learn the words that fail most, but it also means that words recently added don't make it into the tests too often.

We want two new types of tests:

• One to ask words that haven't been asked too often, i.e. smallest (failed+passed).
• A random one

This snippet of code is everywhere:

dba = Room.databaseBuilder( getApplicationContext(), VocabularyDB.class, "vocabulary-db" ).allowMainThreadQueries().build().getDBAccessor();

Let's 1) refactor it into some class or method that we can reuse, and 2) hopefully run it just once e.g. store it in some attribute somewhere?

The options stored in the DB should be also visible to the user. Currently there is a "ListConfigOptionsActivity" but it's just a skeleton, i.e. it does nothing.

Implementation should probably be similar to the visualization of the dictionary in "ListDictionaryActivity".

LeantWord & Translation? I don't like the "Word" bit because a "Word" could be a class. Just "learnt" and "translation"? "Native" and "Translation"?

Following message seen in AndroidManifest.xml:

"App is not indexable by Google Search; consider adding at least one Activity with an ACTION-VIEW intent filter. See issue explanation for more details. less... (Ctrl+F1)

Inspection info:Adds URLs to get your app into the Google index, to get installs and traffic to your app from Google Search. Issue id: GoogleAppIndexingWarning More info: https://g.co/AppIndexing/AndroidStudio "

This issue requires some investigation on how to do that. Cloud storage? CSV?

Additionally, it would be pretty cool to be able to share dictionaries (for extra points)!

There should be a "+" button where we can add words to the dictionary from other places. This should replace the ad-hoc activity that is only accessible from the main screen.

Right now there is a 1:1 mapping between words and their meaning. This is not how languages work. For example, in Hindi there are several words for "uncle". We want to be able to 1) store multiple meanings of a word, and one meaning be suitable for many words, i.e. many-to-many relationship.

This issue requires modifying the DB, which requires adding a migration path from the old DB number.

WordAdapter creates a new view in getView(), but this is not optimal. We should check if the current view is suitable (list_dictionary_element or list_dictionary_header), and reuse it if appropriate.

This is because the results are calculated by comparing the number of incorrect questions against the total number of questions, instead of against the number of answered questions so far.

There is an unchecked cast to ArrayList of the list of incorrect words coming from the quiz into the results activity. We need to check it.

Right now it's only hindi, which renders this option useless for future uses.

message "you failed the following words" still appears, followed by nothing

It should be rejected

When selecting a word for deletion, the app deletes it directly. Someone could hit the button by accident and would lose a word, which could be annoying. Let's add a dialog prompting for confirmation from the user on the deletion.

We currently allow queries to the Room DB in the main thread by calling allowMainThreadQueries(). This may lock the UI for a long time if the query is long. I think this is already affecting responsiveness negatively when opening the Dictionary list as the list of words increase.

This could be done in two ways:

• Do DB queries in a separate thread (not sure how yet).
• Return instances of LiveData or Flowable in the queries.

More information on how to do it properly is available here: https://developer.android.com/training/data-storage/room/accessing-data.