Giter Club home page Giter Club logo

Comments (3)

franciscolourenco avatar franciscolourenco commented on August 24, 2024 1

v3.0 is good enough, this is not that important 👍

from payload.

jacobsfletch avatar jacobsfletch commented on August 24, 2024

@franciscolourenco the demo likely displays a fallback favicon that the browser has cached on the top-level domain (payloadcms.com). That site has a favicon.ico hosted on the root of the application: https://github.com/payloadcms/website/blob/main/public/favicon.ico. Unsupported browsers will use this when no valid favicon was found, including sub-domains, it seems. But adding this to the Payload Admin Panel in not an option, however, because favicons need to be 100% configurable through the Payload Config. A static file would fall outside of this capability.

BUT in 3.0, we've actually moved to PNG favicons (dy default), so this is no longer an issue. With this new pattern you can provide your own .svg, .ico, or any other icon format. For this reason I'm going to go ahead and close this ticket. For 2.0, Safari would either need to increase support to SVG favicons, or you'd have to find another way to inject a favicon.ico into the root of your application (not sure if this is even possible, so if anyone has ideas, feel free to leave a comment).

from payload.

jacobsfletch avatar jacobsfletch commented on August 24, 2024

I suppose it's possible for us to extend the favicon config a bit, which would allow you to supply your own .ico file. But this would require an additional set of logic to check the file type in order to properly set the type attribute in the DOM—and this is exactly what we've done in 3.0. Instead of retrofitting support for this, we strongly recommend upgrading to 3.0 if this is an option for you, as that the the more permanent fix going forward.

from payload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.