Navigation in the admin panel is broken if routes.admin is set to "/" about payload HOT 3 OPEN

Hey @r1tsuu I think we should discuss what we want to do here. We would likely need to touch every file that uses adminRoute or routes.admin, and then adjust them accordingly. There are some places that will break if the admin route is "/" or "", bc the links or routes generated using it will be incorrect, i.e. "/admin/[route]" will become "//[route]".

You could in the meantime, add a redirect in your next config like so:

export default withBundleAnalyzer(
  withPayload({
    async redirects() {
      return [
        {
          destination: '/admin',
          permanent: true,
          source: '/',
        },
      ]
    },
  }),
)

from payload.

Hey @r1tsuu I think we should discuss what we want to do here. We would likely need to touch every file that uses adminRoute or routes.admin, and then adjust them accordingly. There are some places that will break if the admin route is "/" or "", bc the links or routes generated using it will be incorrect, i.e. "/admin/[route]" will become "//[route]".

You could in the meantime, add a redirect in your next config like so:

export default withBundleAnalyzer(
  withPayload({
    async redirects() {
      return [
        {
          destination: '/admin',
          permanent: true,
          source: '/',
        },
      ]
    },
  }),
)

The problem is that i don't want to do a redirect here, because what i want is to host the admin panel on a different domain from frontend which is on the same server too.
What i do is i'm using NextResponse.rewrite in the middleware.ts if req.host is for the admin. So my "real" route is still "/admin" and i didn't change any folder structure.
I sucessfully achieved this working with providing routes.admin: "" without any broken links.
I'm not sure if it sounds good but if we just map the "/" value to "" in our sanitize function or joi schema then it should be fine, no need to change something else!

from payload.

@r1tsuu I tried that earlier, remapping inside the sanitize function. But after logging into the admin panel I was facing an issue with a Link component somewhere, saying the href was undefined 🤔

from payload.