Giter Club home page Giter Club logo

Comments (8)

nvti avatar nvti commented on September 22, 2024 1

Hey @nvti, meta.icons is supposed to be an array. That way you can set multiple icons in the head of your document, i.e. light / dark mode. Looks like we might've overlooked your PR unfortunately. I really appreciate the contribution regardless. This change did go out in the last beta release, so I went ahead and opened #6759 to resolve thisβ€”let me know what you think.

Hi @jacobsfletch, thank you for your reply. My PR does only 1 thing: sync between MetaConfig type and its validation schema.
I think changing meta.icons to array is OK, your PR is great and I don't have any comment about that.

BTW, there is another small thing in my PR about OpenGraphConfig type (this type is changed, too). Please check in my PR (#6426). If it looks OK, please copy it into your PR. Thanks
packages/payload/src/config/types.ts

export const openGraphSchema = joi.object({
  description: joi.string(),
  images: joi.alternatives().try(ogImageObj, joi.array().items(ogImageObj)),
  siteName: joi.string(),
  title: joi.string(),
})

from payload.

jacobsfletch avatar jacobsfletch commented on September 22, 2024 1

Ahh, rip. Would you be willing to PR for this? Otherwise I will get to this as soon as I can.

from payload.

jacobsfletch avatar jacobsfletch commented on September 22, 2024 1

Merged. Thank you @nvti πŸ™Œ

from payload.

jacobsfletch avatar jacobsfletch commented on September 22, 2024

Hey @nvti, meta.icons is supposed to be an array. That way you can set multiple icons in the head of your document, i.e. light / dark mode. Looks like we might've overlooked your PR unfortunately. I really appreciate the contribution regardless. This change did go out in the last beta release, so I went ahead and opened #6759 to resolve thisβ€”let me know what you think.

from payload.

jacobsfletch avatar jacobsfletch commented on September 22, 2024

Got it πŸ‘ that has been carried over here:

images: joi.alternatives().try(ogImageObj, joi.array().items(ogImageObj)),

from payload.

nvti avatar nvti commented on September 22, 2024

@jacobsfletch you still forgot the siteName field πŸ˜„ It's OK, just a small thing. You can add this in another PR.
the new type of OpenGraphConfig:

export type OpenGraphConfig = {
    description?: string;
    images?: OGImageConfig | OGImageConfig[];
    siteName?: string;
    title?: string;
};

from payload.

nvti avatar nvti commented on September 22, 2024

@jacobsfletch ok, let me open a new PR for this

from payload.

nvti avatar nvti commented on September 22, 2024

@jacobsfletch I created PR #6764 to address this

from payload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.