Comments (8)
Hey @nvti,
meta.icons
is supposed to be an array. That way you can set multiple icons in the head of your document, i.e. light / dark mode. Looks like we might've overlooked your PR unfortunately. I really appreciate the contribution regardless. This change did go out in the last beta release, so I went ahead and opened #6759 to resolve thisβlet me know what you think.
Hi @jacobsfletch, thank you for your reply. My PR does only 1 thing: sync between MetaConfig
type and its validation schema.
I think changing meta.icons
to array is OK, your PR is great and I don't have any comment about that.
BTW, there is another small thing in my PR about OpenGraphConfig
type (this type is changed, too). Please check in my PR (#6426). If it looks OK, please copy it into your PR. Thanks
packages/payload/src/config/types.ts
export const openGraphSchema = joi.object({
description: joi.string(),
images: joi.alternatives().try(ogImageObj, joi.array().items(ogImageObj)),
siteName: joi.string(),
title: joi.string(),
})
from payload.
Ahh, rip. Would you be willing to PR for this? Otherwise I will get to this as soon as I can.
from payload.
Merged. Thank you @nvti π
from payload.
Hey @nvti, meta.icons
is supposed to be an array. That way you can set multiple icons in the head of your document, i.e. light / dark mode. Looks like we might've overlooked your PR unfortunately. I really appreciate the contribution regardless. This change did go out in the last beta release, so I went ahead and opened #6759 to resolve thisβlet me know what you think.
from payload.
Got it π that has been carried over here:
from payload.
@jacobsfletch you still forgot the siteName
field π It's OK, just a small thing. You can add this in another PR.
the new type of OpenGraphConfig
:
export type OpenGraphConfig = {
description?: string;
images?: OGImageConfig | OGImageConfig[];
siteName?: string;
title?: string;
};
from payload.
@jacobsfletch ok, let me open a new PR for this
from payload.
@jacobsfletch I created PR #6764 to address this
from payload.
Related Issues (20)
- richtext-lexical: indent CSS not working
- Search for media from an upload field doesn't work. HOT 2
- payload-3.0-demo repo env and config content and readme inconsistent HOT 1
- richtext-lexical: missing block remove hover animation
- How to dynamically get/set the language of a CodeField for v3
- richtext-lexical: cmd+A within a block sub-field selection is incorrect HOT 1
- richtext-lexical: markdown transformer for links separated by newline not working as expected
- cannot scroll while mouse is hovering over code field
- Calling an endpoint within another endpoint doesn't preserve `req.user` HOT 3
- Issue with Live Preview in Website Template on EC2 Instance in Combination with 'pnpm run build/start' HOT 2
- Payload says in dev mod when run with NODE_ENV=production node server.js HOT 2
- Webpack Caching Issue: "Expected end of object" Error during Navigation HOT 2
- `createClientFeature` returns the wrong type, or `createServerFeature` needs the wrong type
- Downgrade level of `NotFound` error for missing element in GET HTTP request HOT 2
- richtext-lexical: merging cells onto already merged cells throws errors HOT 2
- withPayload.cjs does not exist, breaks cjs next.config.js HOT 2
- Validation on Blocks doesn't stop a page from saving
- Admin Condition seems to be broken HOT 1
- "disableLocalStrategy: true" still asking for email or nickname HOT 1
- Local API returns `draft` documents with null fields in production
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from payload.