pawartur / django-todo-lists Goto Github PK

Somewhere you have this code:

@receiver(pre_save, sender=ToDoAlert)
def schedule_todo_alert_send(sender, **kwargs):
    if kwargs.get("raw"):
        return

    todo_alert = kwargs["instance"]
    current_celery_task_id = todo_alert.celery_task_id

    if current_celery_task_id is not None:
        # Revoking tasks only works with amqp, redis and mongodb for now (celery 2.5)
        control.revoke(current_celery_task_id)

    result = send_todo_alert.apply_async(args=[todo_alert], eta=todo_alert.time.astimezone(get_default_timezone()))
    todo_alert.celery_task_id = result.task_id

What if the notification is 10 days in the future? I guess you would have a problem, because a message queue isn't meant to store things for so long? Or is that the reason that you used MongoDB?

any chance of a demo app being added to this? I like what I see on the demo site but since everything is served via compressed static files it's tricky at best to extrapolate everything going on and how it ties together

probably much easier for someone with lots of backbone.js experience (not me currently)

though this app doesn't even include a requirements.txt file

the other major player in django-todo world is https://github.com/shacker/django-todo
doesn't come out nearly as clean but is a pluggable app

your readme suggests you wanted this to be pluggable but it looks like that depends upon a very specific workspace environment (yours) but again no references on how to set things up

this is a half rant, I'm working through making this work since I can see significant value in an app like this as part of an existing personal project (not sure if I'll push forward with backbone or migrate to standard jquery) -- probably fork and request a merge within a couple days

in the mean time perhaps updating the readme file to reflect the current jumble vs the envisioned slick install?