What steps will reproduce the problem?
1. Enter incorrect or incomplete LDAP details during setup
2. Login to management.php using internal admin user credentials
3. Update Site->LDAP Settings with correct LDAP details
4. Save changes - pop-up dialog reports that all is well
5. Try to authenticate via LDAP - all is not well!
What is the expected output? What do you see instead?
That once the database is updated with the correct LDAP settings, LDAP
authentication will now succeed. However, it still fails.
What version of the product are you using? On what operating system?
Latest XOT trunk checkout from SVN repository on Ubuntu 10.04 LTS
Please provide any additional information below.
During the setup procedure, the entered LDAP details are actually inserted into
two separate tables: `ldap` and `sitedetails`. However management.php only
updates `sitedetails` with the new data. The table used for the actual
authentication is the other one, `ldap`, which is never actually updated.
Therefore, unless you enter the correct settings during installation you will
never be able to get LDAP authentication working (unless you edit the `ldap`
table directly via a database admin client).
Fixed in attached patch, which causes the `ldap` table to be updated in
addition to `sitedetails`. However I'm not sure whether the data should ever be
inserted into `sitedetails` at all, since this never seems to be used for
authentication.