paveljanda / happy Goto Github PK

As you know Bower is no longer supported. Can you make NPM package to use in projects. You have something for NPM but it is not compiled. Happy.js throws me an error Uncaught SyntaxError: Unexpected token 'export'
Thanks a lot.

It would be great if we had happy-sm, happy-md & happy-lg size modifiers, make the default one little larger (24px?) and use current one as smversion.

Since this package is on bower now you should really consider changing directory structure like I mentioned in #1.

This is standard for frontend components and would probably be best to follow it.

/dist <- compiled assets
/src <- source assets

If you want I can send PR. :)

This code is fine:
<input class="happy primary" type="radio" name="a1" value="a1" checked>

This code raise an exception:
<input class="happy primary" type="radio" name="a1" value="1" checked>
Exception:
happy.js:108 Uncaught SyntaxError: Failed to execute 'querySelector' on 'Document': '.happy-radio[data-name="a1"][data-value=1]' is not a valid selector.

Test in commit.

Sorry for being so pesky,
first composer now this, but I switched to this composer plugin which installs my assets into www/assets and this gives me much more control over by assets in webloader, it would be great having happy there too :)

Directory 'dist' is missing, making it impossible to use with Bower. At least for my basic knowledge.

The problem is in version 2.0.x. Older v1.0.8 was OK.

On Safari 13 and older, there is syntax error in code:
SyntaxError: Unexpected token '='. Expected an opening '(' before a method's parameter list.

Problems are with this code

init = () => {
	this.removeBySelector('.happy-radio');
	this.removeBySelector('.happy-checkbox');

	this.initRadio();
	this.initCheckbox();
}
``` and similars, because public field declarations are not supported up to Safari 14.1.

And as a dependent library for DataGrid it could not be used on older Apple devices.

There is a problem with checkbox (checked state) in the Microsoft Edge (possibly Explorer too).

Here is a picture:

You should use borde-radius in percentages, I think 100% for radio and 15% for checkbox would be great.