pavel-novikov / db-mysqldump Goto Github PK

It's just working bad, exporting only part of the tables.

I changed the code a bit, so it dumps to file-system instead of browser
(please see attached file for reference).

But as the classes' output looks like, it just can't be re-imported.

Instead of the regular default values there's YES/NO displayed
(as the DESCRIBE command shows for column DEFAULT).

The output strings are not being escaped properly. Two changes are recommended:

1) Turn on utf8 (most databases use this encoding nowadays). Add this to the 
end of MySQLDump->connect()

    mysql_set_charset('utf8');

2) Change what will no be line 49 in MySQLDump->list_values() from this:

    if (!is_integer($vrednost)) { $vrednost = "'".addslashes($vrednost)."'"; } 

to this:

    if (!is_integer($vrednost)) { $vrednost = "'".mysql_real_escape_string($vrednost)."'"; } 

Advantages of this addition?
1. Allows for changing which db is dumped.
2. Does not store any passwords.
3. Normal users cannot do the dump as they don't know the password.

What is the general design idea?
The primary design will have a field for each of the standard option types:
    Host.
    Database.
    User name.
    Password.

What steps will reproduce the problem?
1. Run the script on a database of 1MB or Higher.

What is the expected output? What do you see instead?
Most users would expect a clean .sql or .sql.gz file output. This method
needs to be released as noted in Issue #1.

Please use labels and text to provide additional information.