paulmillr / async-each Goto Github PK

http://blog.izs.me/post/59142742143/designing-apis-for-asynchrony

console.log('should be 1')

function sync(a, next) {
    next(null, a)
}

each([ 'alpha', 'bravo', 'charlie' ], sync, function (err, result) {
    console.log('should be 3')
})

console.log('should be 2')

should be 1
should be 3
should be 2

The callback should always be called asynchronously.

@paulmillr The recent 1.0.4 release introduced a bug (also present in 1.0.5).

Since the count of items processed is no longer counted and the callback is executed when the last item is processed, we can have, and will likely have, a case where the last item finishes being processed before other items, causing the callback to be executed before the other items are finished.

The processed items must be counted in some fashion for this to work correctly.

@paulmillr

https://github.com/caolan/async/blob/master/lib/async.js#L940-L945

I'm not sure if there's a good reason for the differences in how it's done here, but considering async's visibility, I assume their method is sound.

You already have index in scope, it seems like count is redundant and can be removed. Instead I believe you can check index === items.length - 1?

Any reason not to be 1.0.0?

The reason:
typeof module === 'object' in component env, module is a function. As a fix I suggest to use:
typeof module !== undefined

The MIT license explicitly requires to attach the full license text to the code or any distribution. Without this the license isn't fulfilled by the project itself and thus invalid.

Can this be remedied pls ?

Hi, could you please release a new patch version of async-each which contains the license file you added?

Thanks :)