paulgibbs / buddypress Goto Github PK

Update tokens in email code and in backpat filters for the rename after mercime's recent chagnes

Hi Paul-

I looked into the welcome screen styling question and made some simplifications:

Here's a gist of the code: https://gist.github.com/dcavins/a927d179b69b4e33d034

e.g. https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-phpmailer.php?rev=33142#L2919

the localdomain fallback string bit

@timersys I had the feeling I'm going to have a lot of questions about the code so opening this ticket for all of them. If you could quote the question when you reply, that will help us track the conversation. Thanks.

Review backfilters after updating token names and see if it still works -- it was breaking a filter hooked to bp_get_email_property,

Maybe some of the old emails suck. Make the words better words.

If we do any fancy HTML thing, we need to remember to add the plain text version as the post_excerpt.

It occurred to me that the first suggestions that will arise will be how to add site branding to the emails.

To this end I'm experimenting in a new branch and have added and testing a new control in the header section to add an image, initially this is a simple option to select from media library and have the image aligned across the top, and due to the boring varied client handling of images will be an img tag and link back (recipient can decide whether their client shows these or not )

I'll probably add a checkbox to allow disabling of the site name string, later that could be extended to have the site name act as a positioned overlay on the image quite easily.

This initial implementation is simple and should extensible without causing any issues if already in use.

The emogrifier library requires PHP >= 5.4 (and the next major version will require 5.5+).

BuddyPress supports back to 5.2, like WordPress, so I don't know what to do here. @timersys, what's emogrifier used for? Do you think we can make do without it (what can't we do without it?)? Do we need to write a custom fork for 5.2 compat? Or use something else?

I note that the email template describes an element for preheader text (currently having hardcoded placeholder text) and set to 'display: none;'

What is the intention here for this? It is hidden in clients such as Thunderbird but is shown on Android.

It seems that if this is left in ( equally it could be removed as not massively relevant, it is somewhat an email marketers tool) then it would need to be put under the control of the site admin, perhaps a checkbox to enable/disable and selection between message excerpt or user added string?

As it's possible to add images in email post body and as the current email template has a max width any images wider than this max width can overflow the width.

Tested adding max-width & height auto to the emdeded img{} ruleset to prevent this which seems effective in desktop and Android.