Giter Club home page Giter Club logo

Comments (8)

pulse00 avatar pulse00 commented on May 15, 2024 1

You would, therefore, have to sign a CLA before any PRs could be accepted.

Sure, i would have expected that anyway :)

I'll discuss when we can start to work on this with my team next week and get back to you as soon as i have new info!

from spring-content.

paulcwarren avatar paulcwarren commented on May 15, 2024

Hi, @pulse00 there is partial code for elasticsearch. It got started soon after we added support for solr but never got finished as no one was asking for it at that time. If you would like to use it then we can bump the priority and pick it up in the next release. If I recall there isn't too much left to do. If you feel brave enough also feel free to fork the code and have a stab at it yourself. We would gladly accept a PR for that.

Are you planning to use Spring Data Elasticseach for storing the content metadata as well as for fulltext search?

from spring-content.

pulse00 avatar pulse00 commented on May 15, 2024

Are you planning to use Spring Data Elasticseach for storing the content metadata as well as for fulltext search?

Yes. in fact we've currently migrated to spring-data-elasticsearch 3.2.0-M1 which has finally support for the new high level rest client built into elasticsearch-java.

We sure have resources to work on that indexing feature in the upcoming weeks, however i've noticed that your existing codebase uses jest for communication with elasticsearch.

As we've just put some considerable effort into removing jest from our codebase (we assume that the native elasticsearch rest client will be the way to go in the future), i'm wondering what's the plan regarding jest / native rest client for spring-data-content before we start to work on a PR.

from spring-content.

paulcwarren avatar paulcwarren commented on May 15, 2024

I also assume the native client will be the best choice moving forwards so happy to switch over to the same dependencies as spring-data-elasticsearch 3.2.0-M1 in order to get that new client libraries. I would hope these will just become spring boot managed dependencies, if they aren't already.

One other point before you cut any code. Spring Content is a community project atm but our intention is that it will eventually be donated to Spring proper. To that end, we are managing contributions through standard CLAs. You would, therefore, have to sign a CLA before any PRs could be accepted. The sole intention of this is to ease the transition in the relevant Spring GitHub org should the Spring team see enough value to want to bring it in.

from spring-content.

paulcwarren avatar paulcwarren commented on May 15, 2024

Hi @pulse00,

Checking back in on this. It's been a while and I was wondering what you folks decided to do with this in the end. I have at least one other customer requiring the Spring Content Elasticsearch module to support fulltext indexing and in their case Versioning too. So, if you didn't pick this up I plan to do so for the next release (0.9.0).

If you did pick it up then would an extra pair of hands be useful?

Thanks
_Paul

from spring-content.

pulse00 avatar pulse00 commented on May 15, 2024

@paulcwarren sorry for the late reply - unfortunately we did not have much focus on this due to lack of resources - what is your timeframe for this?

we would most likely start with this mid/end june.

from spring-content.

paulcwarren avatar paulcwarren commented on May 15, 2024

Thanks for getting back to me. I know how it is re lack of resources!

Almost there with the first cut of support for full-text indexing with elasticsearch. Should be in a position to cut 0.9.0 by the end of next week, if not a little before. So, if you have something kicking off mid to end June I think this is fine and we will be done well in time.

from spring-content.

paulcwarren avatar paulcwarren commented on May 15, 2024

As discussed 0.9.0 adds basic support for elasticsearch full-text indexing and search. When you get to it please let me know if this meets all of your requirements, or not. In the meantime, I am going to close this issue. Feel free to re-open if there is anything on this thread that you wish to continue discussing. Thanks for raising this. I think this is an excellent addition to the project.

from spring-content.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.