Division by zero when rescaling vertically aligned components about netgraph HOT 7 CLOSED

Hi Pablo, thanks for raising this issue. Great MWE, even better solution. Do you want to create a pull request with your changes?
Alternatively, if you let me know the email address that you use on github, then I can add you as a co-author to the commit.

from netgraph.

Hi!
Done, I just created the PR. I created this Github account just so I can inform you of this bug, so this is my first PR for a public project. It is tiny, but I hope it is along the lines of what you expected.

from netgraph.

I created this Github account just so I can inform you of this bug, so this is my first PR for a public project.

Thank you very much.

It is tiny, but I hope it is along the lines of what you expected.

You are doing great!

Typically, small PRs are much more preferable to large PRs, and if you have a large PR, it is usually better to split it into several small PRs. The best outcome for a pull request is if the maintainer can simply accept it, and merge. If the PR is very large, there are bound to be some issues that need to be addressed before it can be merged. If instead you split the large PR into many, self-contained small PRs, most of the changes can readily be merged, and only the problematic bit goes into the discuss/amend/re-submit loop.

from netgraph.

Yeah, I absolutely agree. Small PRs are so much easier to review in-between other tasks :)

from netgraph.

Brief question; how often to you release a new netgraph version, i.e. how soon do you think this fix will be available via pip? No pressure, just trying to understand when this fix will be available to colleagues :)

from netgraph.

I have parked the changes on the dev branch at the moment. I haven't tested the current state of dev branch thoroughly yet. It passes all automated tests but I struggle with automating the testing of some of the interactive functionalities, so those still need to be tested manually. I will test & merge the dev branch into master (and push to PyPI) once I am finished with some other changes that I am working on.

In the meantime, your colleagues can install the dev branch via pip in this way:

pip install https://github.com/paulbrodersen/netgraph/archive/dev.zip

from netgraph.

I just merged the dev branch back into master, and updated the packages on PyPI. A simple pip install netgraph should now suffice.

from netgraph.