Giter Club home page Giter Club logo

patternengine-node-mustache's People

Contributors

bmuenzenmeyer avatar bramsmulders avatar colynb avatar donaldpcook avatar evanlovely avatar geoffp avatar getsetbro avatar ivanmayes avatar joemcgill avatar johngerome avatar kyleknighted avatar kylewelsby avatar marcinmodestowicz avatar robinsonaaron avatar scottnath avatar stevedesmond-ca avatar tannerhodges avatar torbs avatar walmokrani avatar zacanger avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

patternengine-node-mustache's Issues

Trying to render subsequent lists using listItem will render the contents of the first section in every following section

I am using Pattern Lab Node v2.9.3 on Linux, using the gulp configuration.

Expected Behavior
Foo:
{{#listItems.one}}foo{{/listItems.one}}
Bar:
{{#listItems.one}}bar{{/listItems.one}}

should render to

Foo:
foo
Bar:
bar
Actual Behavior
Foo:
{{#listItems.one}}foo{{/listItems.one}}
Bar:
{{#listItems.one}}bar{{/listItems.one}}

actually renders to

Foo:
foo
Bar:
foo
Steps to Reproduce
  1. Install fresh edition-node-gulp.
  2. Add a new pattern with the above code.
  3. Run gulp patternlab:build and inspect the rendered HTML in /public/patterns/xxx/xxx.markup-only.html.
Additional Notes
{{#listItems.one}}foo{{/listItems.one}}
{{#listItems.two}}bar{{/listItems.two}}

renders as expected.

I don't have the time to test more cases right now.
Also hope this is an issue with the mustache patternengine, not that I post it to the wrong place.

styleModifiers not reset?

I am using Pattern Lab Node v2.11.0 on Mac, using the webpack configuration.

Expected Behavior

When I include a pattern twice with different style modifiers, the patterns should be rendered with those style modifier differences.

Actual Behavior

When I include a pattern twice with different style modifiers, the pattern that is rendered first will overwrite all styleModifiers of the second pattern that is rendered.

Steps to Reproduce

Difficult to reproduce. What I have is a component called skew I call like this:

{{> components-skew }}

In a very different place, I call it like this.

{{> components-skew:inx-card__image-title|inx-card-skew--alpha|inx-card-skew--end(image: false) }}

As soon I add the second include, the first include will render with the exact same styleModifiers

Support for multiple list items per mustache template

As per the documentations, multiple list items doesn't support. Could anyone help me how I can do this.

And another question I have is why should we strict to a format like this when defining a list item where it has to defined as an array rather just a simple array.

{
  "1": {
    "author": "author 1"
  },
  "2": {
    "author": "author 2"
  },
  "3": {
    "author": "author 3"
  },
  "4": {
    "author": "author 4"
  }
}

More than one space in partial name caused partial not be found in the known partials list

I am using Pattern Lab Node v1.0.0 on Mac, using the gulp configuration.

Expected Behavior

{{> some-partial-with-more-than-one-space-in-the-reference }

Actual Behavior

Partial is not found, and therefore in the node version of patternlab, the template errors.

Steps to Reproduce

See

L103 in engine_mustache.js
var foundPatternPartial = partialString.replace("{{> ", "").replace(" }}", "").replace("{{>", "").replace("}}", "");

It assumes there is only one space before the ending curly brackets.
Suggestion: Should use regex to remove to curly and angle brackets.

Add an .npmrc

I am using Pattern Lab Node ccd426e1dcdd7952a8aae2f092fe931e53ba1792 on Windows

Expected Behavior

For the developers, who might have changed the global registry configs, still the patternengine-node-mustache source should be redirected to npm registry when installing node_modules.

Actual Behavior

The npm installation is failed for those who have changed the global npm config.

Steps to Reproduce

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.