patrickroberts / complex-js Goto Github PK

Hi, nice library. lightweight and so useful.

But trying to make a app, I note that some expressions are not parsed correctly:

Complex.compile('1/a*b*c',['a','b','c'])

returns a optimized function in the browser:

ƒ: anonymous(Complex,a,b,c) {
return this[0].divide(a.multiply(b)).multiply(c)
}

and

Complex.compile('(1/a)*b*c',['a','b','c'])

returns

ƒ: anonymous(Complex,a,b,c) {
return this[0].divide(a).multiply(b).multiply(c)
}

that are different expressions.

* and / operators should be the same precedence and the correct result is the last (a chain of operators without grouping).

Thanks

complex-js version: 5.0.0

Addition of Mocha + Chai + Istanbul BDD-style unit testing and code coverage is currently in progress.

Hi Patrick,

I used your brilliant library to prepare a nice educational tool.
It is available here
http://plansoft.org/edu

I have an idea to add my code to your repository, what do you think?
Otherwise I will create my own repository.

Good job on complex.js !

Kind regards
https://github.com/MaciejSzymczak
[email protected]

(Don't worry you are not mentioned in my code yet, I will fix it soon, this is just a working code.)

> C = require('complex-js')
> C(0,0).pow(C(1,0))
n { abs: 0, arg: NaN }
> C(0,0).pow(C(1,0)).real
NaN
> C(0,0).pow(C(1,0)).imag
NaN

The case of pow(0+0i, ...) needs to be handled specially, since you can't compute the angle. I think the logic should be:

   if (y.real === 0 && y.imag === 0) {
    return C(1, 0)
   }
   else if (x.real === 0 && x.imag === 0) {
    return C(0, 0)
  }
  else {
    ... existing logic ...
   }

What are you thoughts on extending functionality so as to pass numbers to complex operators like:

> Complex(1,1).mult(10)
Complex( 10, 10 )

Thanks