Giter Club home page Giter Club logo

noso-faucet's Introduction

My Awesome GitHub Repository

Hey there! 👋 I'm a 24-year-old developer from Ukraine, passionate about coding and technology. 🚀

Anurag's GitHub stats

About Me

  • 🌐 Currently learning Swift and Python
  • 💻 Coding since the age of 13
  • 🎯 Experienced in PHP, JS, Kotlin, Java, Dart, Flutter, C++, CSS
  • 🤖 Love writing code and exploring new technologies

Technologies I Work With

  • Backend: PHP, Java
  • Frontend: JavaScript, Dart (Flutter), HTML, CSS
  • Mobile: Kotlin, Dart (Flutter), Swift (learning)
  • Other: C++, Go, Python (learning)

Projects

Here are some of the projects I've been working on:

  1. My Notes: My Notes is a user-friendly app for capturing and organizing your ideas, tasks, and memos. Stay organized and productive with this simple note-taking solution..
  2. NosoSova: Multi-platform wallet for NosoCoin && SovaRPC (CLI && GUI)
  3. NosoDart: Implementation of basic cryptographic functions for Noso

Feel free to explore my repositories for more exciting projects!

Connect With Me

Let's Code Together! 🚀

I'm always open to collaboration and new ideas. If you have any suggestions, feel free to open an issue or create a pull request. Let's make awesome things together! 😊

noso-faucet's People

Contributors

pasichdev avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

zyztek

noso-faucet's Issues

On file composer.json, about authors

Hey Andrii (@pasichDev)

If you have a closer look the block for authors is in the plural, as in "authors" not "author".

So you don't have to put yourself and me on the same entry:

    "authors": [
        {
            "name": "Gustavo Carreno / Andrii Pasichnik",
            "email": "[email protected]"
        }
    ]

I think you can do it like this:

    "authors": [
        {
            "name": "Andrii Pasichnik",
            "email": "[email protected]"
        },
        {
            "name": "Gustavo Carreno",
            "email": "[email protected]"
        }
    ]

And please, I'll always be second on the list. You're the one doing all the work. I'm just the guy bitching over your shoulder on how to do it LOL 🤣 🤪

Cheers,
Gus

Another suggestion: All URLs should be relative

Hey Andrii (@pasichDev),

I've noticed that in both your initial code and this new version that you always have a config variable with the site and port.

This should either be inferred from the $_SERVER array, or never be mentioned anywhere by always using relative paths.

This allows for very easy deployments without having to have another variable to configure.

We have config vars for the stuff we can't get from $_SERVER and/or $_ENV, like database credentials and such.
The rest must be collected from the environment that the app is residing, not ask the person that deploys to have another variable to mess up 😃
Humans tend to make mistakes. Collecting data from the environment is safer that having a human guess what it is.

Cheers,
Gus

Problems IMPORTANT

1. Clearing cookies after ref authorization, namely deleting ref cookies!

Dangerously close to reinventing the wheel

Hey Andrii (@pasichDev),

Might as well say this now, in these early stages, than say it later when you've invested too much time in this architecture.

With a router(/dispatcher), a semblance of controllers and a very rudimentary layout/templating system, we are now in the middle of SlimPHP's territory.

So my arguments are these:

  • Granted, you don't need a framework for this, but by using one you don't have to create and test the boilerplate code for the basics.
  • At the moment, your code is functional but lacks any ways of testing it via automation, the Continuous Integration of the CI/CD pair.

Yes, you can curse me and throw a fit of rage, cuz in essence this would be another re-write ☹️
Hence me creating this issue now, so we can discuss this possible change of path.
Hint: This should be a discussion and I think you should open that area on the Project settings 😃

Have you ever done any work using the SlimPHP framework?
At the moment, SlimPHP is the most light weight of all the PHP frameworks, usually used for very simple projects or for rapid prototyping of a possible more complex one.

What are your thoughts on this subject?

Cheers,
Gus


  1. https://www.slimframework.com/
  2. https://github.com/slimphp

Admin panel development

  • First you need to make an authorization page with a password! (After entering the password, if it is correct, then we will create cookies for the admin, valid for one hour)
  • You also need to implement in order to register the address of the admin wallet in the config
  • When the user is authorized, we must go to the page for changing settings
    .. I will add and update

Minor typo on the english word `route`

Hey Andrii (@pasichDev),

Just FYI, the English word for маршрут, путь is route, with an e at the end.

Like I said, minor typo, but if we are doing it in English, in the context of readability, we should correct these minor typos :)

Cheers,
Gus

Some files are missing the php after <?

Hey @pasichDev,

At least index.php and coreclass.php are missing the php after <?

Please make sure that all your PHP containing files start with <?php and that they are UTF8 with no BOM.

The code is un-runnable at this present stage.

Cheers,
Gus

Have a clean webroot folder with no code

Hey @pasichDev,

Would it be OK if you modified your folder structure to the following?

  • config/
  • src/
    • (All the code)
  • webroot/
    • index.php <-- this has little to no code and just gets all the functionality from the src folder above
    • .htaccess
    • img/
      • (all the images)
    • js/
      • (all the Javascript)
    • css/
      • (all the Cascading Style Sheets)
  • README.md
  • LICENSE
  • .gitignore
  • .gitattributes

This way when we create the virtual host on apache2, we point it at the folder webroot.
This leaves all the code OUTSIDE the webroot folder and apache cannot serve it, so no need for the defined(pasich) or die().

This will also begin to prepare you folder structure to use composer.
We need to have a talk about Name Spaces on your classes and probably use a better HTTP Client to access the explorer API.

But the composer stuff can wait, first the folder structure, please 😃

Many, many thanks!!

Cheers,
Gus

Error

Ошибка в проверке на существование кода верификации, в коде сделано проверку на пост.. а нужно на запрос из БД

Typo on the Faucet View php file name

Hey Andrii (@pasichDev),

The file is named faucetVIew.php but should be named faucetView.php.

Remember that filenames in *nix environments are case sensitive. It may work in a Windows environment, but it's going boom on my Linux 😃

Cheers,
Gus

What is the purpose of locking as resolved?

Hey @pasichDev,

You're locking the issues that you already solved as locked as resolved. I wasn't aware of this possibility but it makes no sense for closed issues, at least in my point of view.

Since you locked comments to only collaborators, and I'm not one, I can't comment on any issue after you locked it, either open or closed.

If this is a common practice, I haven't seen it yet and you can probably explain it to me :)

Many thanks in advance.

Cheers,
Gus

These are suggestion due to my obessive compulsion to have things readable...

Hey @pasichDev,

I've just had a quick look at your changes and I think you did great, with even picking up a bit of the MVC with controllers 😃

I would wish that you would use CamelCase in your code's name spaces and/or classes, but again, not necessary for the code to work.

I have this compulsion to make my code as readable as possible, so I tend to adhere to a lot of the PHP conventions(not rules, I know) that I've picked up with 15+ years on PHP, but this does not mean that everybody should be as "anal" as I am 😃

I have this thing about an unspoken rule that involves lead programmers being killed by buses. If they are killed, and the code they leave behind is only readable/understandable to that dev, then the poor dev that comes to continue that code will have a very bad time. And I'm a firm believer of : Do unto others, like you would want others do unto you.

All in all, I love that you were able to understand my template and you even did a mini router and controller!! This means you really have a good understanding of how it should be 😃

Congrats!!

Cheers,
Gus

Отправка платежа

Реализовать подачу заявки пользователя на выплату монет, а в админке на выплату

Reauthorization!!

Add a check for the existence of an authorization to avoid reauthorizations

What else needs to be done on the project?

  • RPC payments
  • IP Tracking - Against Multitude!
  • Admin panel #33
  • Need to add an ip address
  • After the development is completed, you need to remove the permissions to show SlimPHP errors

The list may be expanded...

FYI: Why I included guzzle

Hey Andrii (@pasichDev),

You're probably wondering why I included guzzle on the requirements for this project.

I did it because you were getting info about accounts via the Explorer API. I then had a look for the most used HTTP client in the PHP world and it's the guzzle one.

That's the reason behind including the guzzle HTTP Client.
Doesn't mean it needs to be there.
If you find that guzzle is not for you or it's too heavy for such a small project, please feel free to use another.

Cheers,
Gus

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.