pascal-zarrad / psh Goto Github PK

Is your feature request related to a problem? Please describe.
GitHub introduced the security tab, we may make use of it.

Describe the solution you'd like
Create a SECURITY.MD and make use of GitHubs new security features.

Is your feature request related to a problem? Please describe.
Currently the contribution guidelines are not optimal and have some clear typos. That should be fixed.

Describe the solution you'd like
Fix the typos by taking the improved version of the guidelines from https://github.com/pascal-zarrad/GCaptchaValidator

Is your feature request related to a problem? Please describe.
It should be possible to prevent the execution of all plugins using a parameter.

Describe the solution you'd like
Disable plugin execution when --disable-plugins is passed as parameter to the install script.

Describe the bug
The project moved to GitHub Actions but still displays the Travis badge in the README.
This badge should be changed to the GitHub Actions one.

Is your feature request related to a problem? Please describe.
Currently CI and Repo are split and in the past Travis had here and there some problems regarding repository connection.

Describe the solution you'd like
The project may switch to GitHub actions instead of Travi. This would seamlesly integrate with GitHub and could reduce possible problems due to the reliance on third party services.

Describe alternatives you've considered
If GitHub actions does not fit the needs of psh, it should be kept as it is.

Describe the bug
apt upgrade is being executed during dependency installation. As apt update is required, we should not execute an system upgrade during psh installation.

To Reproduce
Steps to reproduce the behavior:

1. Execute the installer with a missing dependency
2. sudo apt upgrade is being executed during installation

Expected behavior
sudo apt upgrade is no longer being executed during installation

Is your feature request related to a problem? Please describe.
Some might want to execute psh as part of a setup script that quickly preconfigures a Linux-based computer. Currently, it is not possible to execute psh with a console parameter that removes all prompts during installation.

Describe the solution you'd like
Add a parameter to the installer which automatically answers "yes" at all installation steps. The parameter should be anything like --unattended or --unattended-install. It would be optimal to also find a way to handle all things that require root permissions and will ask for a password during installation.

Describe alternatives you've considered
Implement the --unattended or --unattended-install parameter, which will skip all yes/no prompts but still asks for the root password if neccessary.

Additional context
As many setup scripts are being executed as root, the alternative could be the better implementation of the feature.

Describe the bug
Due to an unescaped $(tty) in the plugin, the value written to the zshrc is the path of tty (for example: /dev/tty1 instead of $(tty).

To Reproduce
Steps to reproduce the behavior:

1. Run psh on WSL
2. Restart WSL / Install same zshrc on different machine
3. Take a look at the zshrc. It should show the behaviour described in the description.

Expected behavior
The line written in the .zshrc by the wsl-gpg plugin equals export GPG_TTY=$(tty).

Is your feature request related to a problem? Please describe.
Currently, the template system does include any files in the templates directory. This shouldn't be the case. It should only include .template.zshrc files.

Describe the solution you'd like
Only include files from the templates directory with the proper file extension .template.zshrc.

Describe the bug
When executing psh on a fresh installation, it can happen that the package sources are out of date and some packages cannot be found.

To Reproduce
Steps to reproduce the behavior:

1. Install a fresh Linux, that does not have all required dependencies installed
2. Execute the psh installer ./install.sh
3. See error

Expected behavior
It should run apt update (at least) and apt upgrade to prepare the system for the new packages.

Environment:

• OS: Linux
• Dist: Ubuntu (but not exclusive to Ubuntu)
• Shell: Bash

Is your feature request related to a problem? Please describe.
It should be possible to prevent templates from being included in the .generated .zshrc. As the template processing is currently one of the most time consuming tasks during installation, it should be possible to disable it.

Describe the solution you'd like
When the installer is being launched with the --disable-templates parameter, the templates should be ignored during installation.

Describe the bug
On WSL 2, /proc/version does output another version. This leads to the usage of the agnoster theme, that is not usable on WSL due to powerline-fonts.

To Reproduce
Steps to reproduce the behavior:

1. Run /proc/version
2. Compare output to the check in the theme loader

Expected behavior
The bira theme is used on WSL 1 & WSL 2

Screenshots
If applicable, add screenshots to help explain your problem.

Environment:

• OS: Windows Subsystem for Linux / Linux
• Dist: Ubuntu
• Shell: Bash

Is your feature request related to a problem? Please describe.
Add API functions to enable plugins to write custom things into the .zshrc

Describe the solution you'd like
Add the function write_zshrc to write to the .zshrc. Add the function write_zshrc_ln to write a to the .zshrc and add linebreak at the end of the input.

Is your feature request related to a problem? Please describe.
The execution of templates is currently really slow. This is due to the fact that the templates are completly read again and again for every type.

Describe the solution you'd like
Only read template information once and read the files again to transfer their content into the .zshrc.

Is your feature request related to a problem? Please describe.
GPG on WSL requires export GPG_TTY=$(tty) to be able to display a password prompt in the terminal.

Describe the solution you'd like
Add a plugin that only adds this environment variable on WSL (like the fallback in the theme-loader).

Is your feature request related to a problem? Please describe.
Our current PR template is outdated.

Describe the solution you'd like
Update the PR template to better match current GItHub features by making use of keywords.

Is your feature request related to a problem? Please describe.
At this time, psh can only be installed for the user that runs the script. It should be possible to mentoin another user as a parameter.

Describe the solution you'd like
Implement a parameter like --user that allows to install psh onto another user account than the current one.

Is your feature request related to a problem? Please describe.
Currently the labels are unsorted, that should be changed.

Describe the solution you'd like
Change the GitHub issue labels to sort them and update the stale workflow to support the renamed labels.
We can apply numeric prefixes with some letter that descriptes the scope of a label (for example: C1 = Category 1)