particular / nservicebus.heartbeat Goto Github PK

Dependabot couldn't reach https://www.myget.org/F/particular/api/v3/index.json as it timed out.

Is https://www.myget.org/F/particular/api/v3/index.json accessible over the internet? If it is then this may be a transitory issue and can be ignored - Dependabot will close it on its next successful update run.

View the update logs.

Currently when you add the heartbeat plugin, you can only configure the TTL and interval. In addition, make the feature itself on/off via configuration so it can be controlled programmatically.

See discussion in: https://discuss.particular.net/t/heartbeat-monitoring-off-on-programmatically/666

After an issue we saw in production where the endpoint's message pump stopped working (Azure Transport) and the endpoint heartbeats seams to continue reporting the endpoint is running... I had a chat with @boblangley and he explained the heartbeat plugin is not using the message pump, so this makes this a bit useless?

The whole point is to detect whether the endpoint is functioning... is it not?

Even though the endpoint failed to start due to an exception in a feature startup task, heartbeats are send continuously indicating endpoints are healthy incorrectly.
We discovered this issue when we encountered an issue with performance counters Particular/NServiceBus.Metrics.PerformanceCounters#176 . It took a while to track it down as service pulse indicated incorrectly that endpoints are healthy. However, its possible with exception in any feature start up tasks.

I have modified your multihosting sample to reproduce the issue here.

Please note that this is in a multi-hosting scenario.

NServiceBus - 7.4.4
NServiceBus.Heartbeat - 3.0.1
NServiceBus.Transport.SqlServer - 6.2.0
Runtime : netcoreapp3.1 

The SimpleJson codebase is not maintained and is fairly old. This constitutes a maintenance risk, and while there are no known vulnerabilities, if there ever were any detected, it's unlikely there would be a fix.

It should be possible to replace SimpleJson, perhaps with System.Text.Json, although some migration may be required.