parth-io / ped Goto Github PK

When adding a past appointment with an invalid date, the earliest valid date gets automatically chosen. This is incorrect behaviour, as it can lead user typos to be accepted.

For example, the command appt 6 on/29-02-2022 diag/Common cold, viral flu m/Panadolx m/Lozenges is incorrect because of Feb 29. As seen in the screenshot, the date get automatically chosen to be 28 Feb without any warning to the user. I only discovered this bug because I meant to type 29 March, but my fat fingers got in the way and I typed 2 instead of 3.

The length of the User Guide can be reduced, to reduce information overload and to make it easier to navigate. The problem that I faced was a very long page, and I had to keep scrolling up and down the page or to use the find shortcut on my browser to locate the command I wanted to read.

Part of the problem is the length of the section for get. I think it can be shortened with the help of a table which only states the prefix (/n), the property to search by ("name") and a single example to demonstrate the intended usage. Details of the format (such as it being case-insensitive for "name", etc.) can be included using a collapsible section.

When help is typed, a help window should appear visibly. However, as shown in the screenshot, the help window is not fully visible and not even maximisable. I am running Linux, so I am not sure if that is causing an issue. The details of my Linux system:
5.15.0-52-generic #58-Ubuntu SMP Thu Oct 13 08:03:55 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

There are a couple of permutations of get's prefixes which seem to be running successfully despite being incorrect. This is one of them: get /wn /inp /outp. A suggested behaviour to implement is to either parse the first or the last prefix only, or to simply throw an error if multiple prefixes are detected.

edit INDEX ua/ should display an error message if there are no appointment details for the patient, for example for the case for Amy Toh. The reason for this is that it is meaningless to display a success message, because in this case the command did not edit anything yet the UI displays a message that says something was edited successfully..

The get /appton command does not perform any action after I type it and press <Enter>. Furthermore, it does not show up if I press the UP key to scroll up and view previous commands. I suspect that the None values might be causing an issue.

Here is a link to a quick recording that attempts to get the appointment date of Bernice Yu:

video:https://raw.githubusercontent.com/parth-io/ped/main/files/fc1aa477-9df6-41ca-b7f1-69082731451c.mp4

Here is a screenshot of my current persons' list:

Here is the checkup.json file at that precise moment when I was entering the command (rename it to json):

checkup.txt

The user guide states that to retrieve the next-of-kin data for a patient, you can use the get /nok PATIENT_NAME command. However, the behaviour of the command is inconsistent with what is implied by the formatting/structure of the user guide. The /nok prefix is under Locating patients, as shown here:

Locating patients: get

by next-of-kin data: /nok

The implication of this in the UG is that you can locate patients by searching for their next-of-kin data.

But the command locates next-of-kin data by searching for a patient's name.

The object of our search is different, and confusing to those reading the User Guide. This command can be moved out to a separate section, which can be labelled like this:

Getting next-of-kin data

Steps to reproduce:

1. Pick an existing user: Amy Toh
2. The command add n/Amy Toh p/98765432 e/[email protected] nok/Jane Doe, Wife, 82858285 pt/inpatient hw/south fn/3 wn/D690 m/panadol m/ibuprofen should display an error message, which is expected.
3. The command add n/Amy toh p/98765432 e/[email protected] nok/Jane Doe, Wife, 82858285 pt/inpatient hw/south fn/3 wn/D690 m/panadol m/ibuprofen does not display an error message, which is not expected.

I may be wrong, and this may be an intended feature that needs to be documented in the user guide. However, it is reasonable to expect that names of most persons start with a capital letter and to expect Amy toh to refer to the same person Amy Toh.

It seems that the table listing the features in the User Guide, as shown in the screenshot below, is meant to be hyperlinked but it is not.

The add command example in the command summary does not work as the ward number is incorrect.