paralax / punymud Goto Github PK

What steps will reproduce the problem?
1. Get something to inventory
2. ex nonexistent
3. crash
(4. also crashes when sending a word that starts with ex, like "exit")

What is the expected output? What do you see instead?
Give message that you do not have that item.

What version of the product are you using? On what operating system?
Recent svn checkout

Please provide any additional information below.
replace starting near line 137: 

        elif cmd.startswith('ex'):
            if not arg: self.parse('help')
            else:
                found = False
                for o in world.objects_at_location(self.oid) +
world.objects_at_location(self.location):
                    if o.name == arg.strip():
                        if getattr(o, 'description', False):
self.sendto(o.description)
                        else: self.sendto("It's just a %s" % o.name)
                        found = True
                if not found: self.sendto("You don't have a %s" % arg)

What steps will reproduce the problem?
1. Fail to provide the required description to the D command
2. Character gets disconnected


What is the expected output? What do you see instead?
Give an error message, but keep the connection.


What version of the product are you using? On what operating system?
Recent svn checkout.


Please provide any additional information below.
I can't create a clean patch since I've converted all of
the tabs to spaces in my checkout, but you could replace
starting at line 154 with this...

        elif cmd == 'D':
            if not arg: self.parse('help')
            try: oid, desc = arg.split(' ', 1)
            except AttributeError: self.parse('help')
            except ValueError: self.sendto('must include description')
            else:
                try: oid = int(oid)
                except ValueError: self.parse('help')
                o = world.find_by_oid(oid)
                if o:
                    o.description = desc
                    world.save()
                    self.sendto('Ok')
                else: self.sendto('Object %s not found' % oid)

What steps will reproduce the problem?
1. Open mud.py in editor with tab width set to something other than 8
2. Lines indented with tabs will appear to have the wrong indentation


What is the expected output? What do you see instead?
Code should probably conform to PEP  (http://www.python.org/dev/peps/pep-0008/)


What version of the product are you using? On what operating system?
Recent svn checkout.


Please provide any additional information below.
Will attach patch to fix indentation.