Giter Club home page Giter Club logo

Comments (7)

WillAyd avatar WillAyd commented on May 24, 2024
df["day"] = df["t1"].dt.date

^ this returns an dtype=object column contain Python datetime.date objects. dtype=object type columns are loosely typed and not vectorizable

You would either have to live with df["day"] being a datetime instead of a date, or alternately use pyarrow types for a stricter differentiation between date / datetime.

I'm not 100% clear on what your SO question is trying to accomplish since the timedelta you are constructing measures nanosecond differences, but I think this is what you are after:

import pandas as pd
import pyarrow as pa

s1 = pd.DataFrame({"year": [2015, 2016], "month": [2, 3], "day": [4, 5]})
s1 = pd.to_datetime(s1)

df = pd.DataFrame(s1)
df = df.rename(columns={0: "t1", 1: "t2"})
df["day"] = df["t1"].astype(pd.ArrowDtype(pa.date32()))
df["n"] = pd.to_timedelta(df["t1"].dt.day_of_week)

df["week"] = df["day"] - df["n"]

@jbrockmendel for any other guidance

from pandas.

jbrockmendel avatar jbrockmendel commented on May 24, 2024

id suggest using a Period[D] dtype. I'd be open to making obj.dt.date do that.

from pandas.

WillAyd avatar WillAyd commented on May 24, 2024

That makes sense from purely a pandas perspective. I think the downside is when you start talking about I/O (thinking especially with databases where DATE / TIMESTAMP are usually distinct types) I'm not sure how proper our Period support would be. With tools like ADBC the arrow types are already accounted for.

Not going to solve that issue in this issue per se - just food for larger thought

from pandas.

jbrockmendel avatar jbrockmendel commented on May 24, 2024

I'm pretty sure you've mentioned concerns like that before. how difficult would it be to make Period[D] work like you expect with a database? is that concern a show-stopper for many users?

from pandas.

WillAyd avatar WillAyd commented on May 24, 2024

Not sure. To be honest I don't know a ton of the internals on that - I'm sure its possible but I just question if its worth the effort when its already been done by pyarrow.

FWIW using dtype_backend="pyarrow" with read_csv will return dates as date32 already, so that would be something else we'd have to wire into the parsers. date32 is also exclusively a date type; I suppose a period could represent more things that we would have to handle when serializing outwards (ex: Period("D") may make sense for a DATE database type, but what about Period("Q")?)

from pandas.

jbrockmendel avatar jbrockmendel commented on May 24, 2024

when its already been done by pyarrow.

IIUC the suggestion you are implicitly making (here and in #58220) is to have obj.dt.date return with date32[pyarrow] dtype. The trouble with this is 1) pyarrow is not required and 2) it would give users mixed-and-matched null-propagation semantics, which we agreed we needed to avoid when implementing the hybrid string dtype. So for the foreseeable future i just don't see that as a viable option. Period[D] is our de facto date dtype (there has been discussion of making a DateDtype as a thin wrapper around this, but im not finding it on the tracker).

FWIW converting a Period[D] PeriodArray to date32[pyarrow] can be done with:

i4vals = arr.view("i8").astype("int32")
dt32 = pa.array(i4vals, type="date32")

(assuming the astype to int32 doesn't overflow)

from pandas.

WillAyd avatar WillAyd commented on May 24, 2024

Right now I think ser.dt.date should only return a pa.date32 if the series is a pa.timestamp. I agree I don't want to mix those systems, so I see your point about that returning a period when the call is a datetime64.

Im +/- 0 on that versus encouraging more arrow date / timestamp usage

from pandas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.