Giter Club home page Giter Club logo

Comments (4)

Nrezhang avatar Nrezhang commented on May 24, 2024

Hi, is is_year_start supposed to return false for both since they are not on 01/01? or is it supposed to both be True. I guess my question is clarifying what is the exact expected behavior. Is the year start when you have a freq with B the first date that is not Saturday or Sunday?

from pandas.

Nrezhang avatar Nrezhang commented on May 24, 2024

Changed it to check the last character of the string so it handles if there are numbers in front. Works with the example, but not sure about if there are other cases that would break this. The fix seems almost too simple. What do you mean by parse the offset rather than the freqstr?

from pandas.

VISWESWARAN1998 avatar VISWESWARAN1998 commented on May 24, 2024

Changed it to check the last character of the string so it handles if there are numbers in front. Works with the example, but not sure about if there are other cases that would break this. The fix seems almost too simple. What do you mean by parse the offset rather than the freqstr?

Sometimes freqstr may have values like "10YS-JAN". I have changed like this (VISWESWARAN1998@8df36f7)

But I believe @MarcoGorelli is expecting something else.

from pandas.

Nrezhang avatar Nrezhang commented on May 24, 2024

Thank you. I guess we will have to see how @natmokval tackles this issue

from pandas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.