Giter Club home page Giter Club logo

fullstackproject's People

Contributors

palcsta avatar zeeket avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

fullstackproject's Issues

Full Stack project review

Full Stack project review

Here's a short review of your Full Stack course project. The comments in the review are suggestions that you can use in this project or in your future projects. None of the suggestions are required to get a passing grade.

User experience

What did I do?

Register and log in.

Added different sections of asia to the list. Removed some of them by clicking them on the map.

Clicked around aimlessly.

Experience

Would be great to have a country flash when you click it. I had hard time figuring out which country I added or where the country was that I clicked on the bottom.

Favicon could be changed from the react default. Hard to find your app among the hundred tabs I have open.

Code

Code is well split and everything is found right about where you'd expect them to be.

Read the following https://refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.html

And refactor

router.post('/api/login/', async (req,res) => {
to use the guard clause. The result should be a bit more readable code.

This component seems to have multiple components hiding inside of it, consider splitting it into multiple files.
https://github.com/palcsta/FullStackProject/blob/0774edcb3a1ebe65a2f9d0ff3f1e5ee5b62768b8/continents/src/components/SelectedFlags.js

You can use the guard clause to block rendering instead of having logic inside the return statement with:

if (reasonYouDontWantToRender) retun null

And speaking of that SelectedFlags.js file, what's going on with the spacing.

Conclusion

Cool project that could be used for multiple purposes. Adding eslint and prettier to your project would probably help with the readability of your code.

Good job!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.