[Feature Request] Merge queue compatibility about policy-bot HOT 3 CLOSED

Thanks for the initial thoughts on how to support this in Policy Bot! I don't think there's any existing functionality for this because, as you noted, Policy Bot currently only evaluates pull requests, not branches.

Given some initial research on the merge queue feature, I think the best way to support this is to have Policy Bot listen for the merge_group webhook event. I think that handler will do something like:

1. Check for a policy file on the base_ref from the webhook payload
2. If a policy exists, unconditionally post a success status on the head_sha

I don't think we actually need to evaluate the policy, if GitHub is the only thing that can generate merge_group events and push to the special merge queue branches. I think we can assume that if Policy Bot is a required check, GitHub verified it was passing before adding the PR to the queue, and so anything that exists in the queue must be approved.

from policy-bot.

I don't think we actually need to evaluate the policy, if GitHub is the only thing that can generate merge_group events and push to the special merge queue branches. I think we can assume that if Policy Bot is a required check, GitHub verified it was passing before adding the PR to the queue, and so anything that exists in the queue must be approved.

This is my understanding as well, and was sort of what I was hoping for because if it's supported first party by Policy Bot, consumers have very little (nothing?) to do (beyond maybe some additional optional configuration, like disabling this functionality if desired) to adopt merge queue 😄

from policy-bot.

To set expectations, I don't think we will implement this until the merge queue feature is available in a GitHub Enterprise Server release and we can test in our primary environment. That said, if you or anyone else would like to submit a PR implementing the merge_group handler before then, I'm happy to review it or provide advice.

from policy-bot.