Comments (3)
Our expectation is that reverse proxies set an appropriate Host
header for the application (e.g. by using a proxy_set_header Host $host;
directive in NGINX). If that's not possible, then yes, I believe the GitHub OAuth flow will generate incorrect URLs.
It might be possible to update this to use the public_url
values instead. In #334, there was also a request to use theX-Forwarded-Host
header instead of the normal Host
header. If you are unable to set the Host
header in your proxy, does it set the forwarding headers instead?
from policy-bot.
Yes, I'm happy to review a PR if you'd like to try fixing this. I think the easiest option is probably to use the existing oauth2.WithRedirectURL
option to set the redirect URL based on the public_url
value.
If you'd like to support other headers instead, I think we first need to update https://github.com/palantir/go-githubapp to enable that in the oauth2
package.
from policy-bot.
I'm building the reverse proxy in JS (to run in Lambda). We are using the node.js fetch function. That is not allowed to override/set the host header. But I can set any other header.
Is a PR welcome?
from policy-bot.
Related Issues (20)
- Request for Advice on Using Policy Bot in Open Source Projects for Testing, Approving, Merging of PRs HOT 3
- If no rule matches can policy-bot not set a failed status on the PR? HOT 1
- `common.IsActor()` does not actually use `ctx` and can be simplified.
- Condition for not having specific label(s) HOT 6
- has_successful_status causes review requests while PR has draft status HOT 5
- Status check clarification HOT 2
- Feature Request: Predicate to skip rule if a file was changed HOT 6
- Feature Request: Option to count skipped jobs in has_successful_status HOT 5
- Clarify why users are "disqualified" when approval is ignored
- Create new production Release 🚀 HOT 1
- Connecting lines broken when hiding skipped rules with errors
- requires.conditions not working correctly in rule HOT 2
- behavior when using `invalidate_on_push` and `ignore_commits_by`? HOT 2
- Rebase invalidates approval HOT 1
- Concurrent deployments can overwrite statuses unintentionally HOT 1
- Status checks not re-run when used with merge queue HOT 2
- Paths in public_url are removed from OAuth routes
- Re-evaluate policy when PR base branch changes
- has_successful_status may use incorrect check-run HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from policy-bot.