add a has_label_in or similar approval rule predicate about policy-bot HOT 5 CLOSED

thinking about this a bit more, it might be better for my use case this were something like a commit_message_contains predicate, e.g.:

approval_rules:
  - name: important people have approved a scary change
    if:
      any_commit_message_contains: "==API_BREAK=="

would trigger the logic if any commit in the PR matches a regex or something.

Reason for this being that we could also have CI builds that might read content on commit messages use that to determine what checks to run, and then policy-bot and the CI builds will be in sync WRT what's being enforced.

from policy-bot.

+1

Specifically, it'd be great if policy-bot could disapprove all PRs that have the DO NOT MERGE label added

from policy-bot.

@bkeyes - does #151 cover the case of disapproving PRs that have the DO NOT MERGE label? Or is it just for approving PRs that have certain labels?

from policy-bot.

It only adds the ability for approval rules to be turned on or off based on the existence of labels. I think the ability to change disapproval based on label conditions is a separate feature request, since disapproval doesn't support any predicates at the moment.

from policy-bot.

Would this work?

  - name: disapprove all 'DO NOT MERGE' PRs
    if:
      has_labels:
        - DO NOT MERGE
    requires:
      count: 1
      users: []

from policy-bot.