Comments (2)
Thanks for reporting this. I haven't actually seen the bot hit the abuse limits before, but we do implement conditional requests and caching to try to avoid regular rate limits (at least for the V3 API.)
Does this seem to happen more on certain types of webhook events? I'm curious if there is a particular handler where we're doing unnecessary work or if this is a consequence of necessary API requests combined with the rate at which PRs are opened.
from policy-bot.
It seems like we're hitting this more frequently internally. A recent example is a user navigating to the details page, and seeing the following issue.
failed to compute disapproval status: failed to get last disapprover: failed to load pull request data: non-200 OK status code: 403 Forbidden body: \"{\\n \\\"documentation_url\\\": \\\"https://developer.github.com/v3/#abuse-rate-limits\\\",\\n \\\"message\\\": \\\"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\\\"\\n}\\n\"\ngithub.com/palantir/policy-bot/pull.(*GitHubContext).loadPagedData\n\t/home/runner/work/policy-bot/policy-bot/pull/github.go:735\ngithub.com/palantir/policy-bot/pull.(*GitHubContext).Comments\n\t/home/runner/work/policy-bot/policy-bot/pull/github.go:297\ngithub.com/palantir/policy-bot/policy/common.(*Methods).Candidates\n\t/home/runner/work/policy-bot/policy-bot/policy/common/methods.go:57\ngithub.com/palantir/policy-bot/policy/disapproval.(*Policy).lastActor\
I wonder if we should slow down some of the graphql queries to better abide by the abuse limits enforced by GH? At least when this occurs, it appears to hit repos that are in the same org, rather than it being a global problem.
from policy-bot.
Related Issues (20)
- [Question] default reviewer for non matching rules HOT 2
- How to ignore a user's approval in one team when the user is member of two approval teams? HOT 2
- Policy bot stuck on `Commit hash does not have a pushed date` HOT 29
- Trouble loading policy from repo HOT 2
- Allow '=' as comparison operator HOT 1
- Misleading documentation about file path regular expressions HOT 1
- AppID ENV Variable not respected HOT 2
- Confusing behavior with skipped checks. HOT 5
- Add feature to use request more reviewers than required count in case of random-users HOT 1
- [Question] Approval by teams agregator
- Declarative Testing of Policies HOT 5
- Certain merges can lead to ignored commits during evaluation
- Request for Advice on Using Policy Bot in Open Source Projects for Testing, Approving, Merging of PRs HOT 3
- If no rule matches can policy-bot not set a failed status on the PR? HOT 1
- Unable to run policy-bot behind a reverse-prxoy HOT 3
- `common.IsActor()` does not actually use `ctx` and can be simplified.
- Condition for not having specific label(s) HOT 6
- has_successful_status causes review requests while PR has draft status HOT 5
- Status check clarification HOT 2
- Feature Request: Predicate to skip rule if a file was changed HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from policy-bot.