Giter Club home page Giter Club logo

Comments (3)

asvoboda avatar asvoboda commented on May 27, 2024

Alternatively, we could create an option to have policy bot fail open instead of failing closed if the 300 file limit or 250 commit limit is reached?

const (
// MaxPullRequestFiles is the max number of files returned by GitHub
// https://developer.github.com/v3/pulls/#list-pull-requests-files
MaxPullRequestFiles = 300
// MaxPullRequestCommits is the max number of commits returned by GitHub
// https://developer.github.com/v3/pulls/#list-commits-on-a-pull-request
MaxPullRequestCommits = 250
)

from policy-bot.

bluekeyes avatar bluekeyes commented on May 27, 2024

I think it will be possible to address this limit via other APIs (should a specific PR hit it). I'd rather not introduce additional configuration options for something that impacts security like this.

As it stands, you already have the ability to override an error with an approval, so the current workaround is to have some kind of fallback rule in the policy that doesn't have a file predicate (e.g. "no approval required for staging files OR the devtools team has approved".)

from policy-bot.

bluekeyes avatar bluekeyes commented on May 27, 2024

As of GitHub Enterprise 2.17 (so probably before May 2019 for Github.com), the limit on this API was increased to 3000 files, and policy-bot was updated in #161. There's still a limit that I'm sure people will hit, but 3000 should be much more forgiving than 300.

from policy-bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.