Whitelist/Blacklist based on author about bulldozer HOT 4 OPEN

Hi @ghtmtt,

Thanks for your interest in Bulldozer! In general we try to make sure our bots do one thing, and to do it well. Thus, Bulldozer respects any required blocking status checks before merging.

We wrote https://github.com/palantir/policy-bot, which allows for more flexible and complicated approval/dissapproval workflows. The bots don't actually know about each other, but they work very well when using required status checks to prevent auto-merging until the "right" set of people or teams have given their +1.

Let us know on the policy-bot repo if any of the existing README is unclear, and we'd be happy to fix it up.

from bulldozer.

Thanks for the answer. So I can use both App to set the workflow, right?

1. if the author of the PR belongs to a team add mark the PR as approved (policy-bot)
2. after a specific time interval enforce the tag of above (e.g. add a label), again policy-bot
3. if the PR has the approved status and the time interval is good, then merge the PR (bulldozer)

Does it make sense as workflow?

from bulldozer.

Policy-bot currently does not enforce that certain labels are set, but otherwise that workflow makes sense.

from bulldozer.

After discussing this more internally, I don't think policy-bot covers all of the same use cases as this feature. As you highlighted in the workflow, you still need to add the whitelisted label/comment if you don't want Bulldozer to operate on every pull request.

I think whitelisting/blacklisting based on user (and potentially group, although this gets more complicated and I'd want to think carefully about it) is a reasonable request. But in combination with #86, I think we'll want to have a plan for how these settings will interact before implementing them.

Right now, if a PR meets any whitelist condition, it is placed on the whitelist. As we add more possible options for whitelisting, the next request will probably be a way to combine conditions. For example, the PR is by a specific author and has a specific label. I'm not sure that complexity is something we want to support (and it would likely mean changing the configuration format) so I'd want to collect multiple uses that require that before implementing it.

For your purposes, is the current behavior (logical OR of all conditions) fine if there was a username condition?

from bulldozer.