Giter Club home page Giter Club logo

Comments (4)

bluekeyes avatar bluekeyes commented on August 30, 2024

How would you feel if there was no message at all?

One of the things I'm looking at is converting Bulldozer to the new GitHub App format, which means it will be able to act as itself instead of as a normal user. In this world, merge emails would say "Merged by Bulldozer [Bot]" or similar, which could make the comment unnecessary. If it worked like this, would you still want a configurable comment for utility and/or fun?

from bulldozer.

sjrand avatar sjrand commented on August 30, 2024

Eh, obviously this is super low priority. If it's more than 10 minutes of work to do in the app format, then not worth it.

from bulldozer.

ungureanuvladvictor avatar ungureanuvladvictor commented on August 30, 2024

@bluekeyes i was looking at https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button and I don't think it is enabled for GitHub Apps. If you look at https://developer.github.com/v3/pulls/#get-if-a-pull-request-has-been-merged there is a small i next to the title to indicate if a certain endpoint is enabled for GitHub Apps.

I think moving Bulldozer to an app will take a while until GitHub enables the required endpoint. Other options would be to use https://developer.github.com/v3/repos/merging/#perform-a-merge but I think this does not support multiple merge strategies.

from bulldozer.

asvoboda avatar asvoboda commented on August 30, 2024

Now that Bulldozer is a GHE app this merge message is no longer needed to let users know PRs were merged by a bot and not a human's oauth token.

from bulldozer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.