pahanix / delegates_attributes_to Goto Github PK

I was wondering why item.attribute? (in the example, this would be u.firstname?) is not delegated.
in the example, you can delegate u.contact.firstname to u.firstname, but u.contact.firstname? is not delegated.
After a quick look in the code, all that needs to be done to support this is adding '?' to the ATTRIBUTE_SUFFIXES array.

changed? is misspelled.

u.profile.about = "Bob"
u.chaged?                 # => true

u = User.last

u.chaged?                 # => false

On at least Rails 3.2.8 using this gem results in the following exception when saving a model:
NoMethodError: private method `changed_attributes' called for #ModelClassName:instance

The visibility of #changed_attributes is inadvertently set to private by this gem and must instead be public as per ActiveRecord::Dirty

Using this monkey patch to force visibility of #changed_attributes to public again rectifies the problem:

class ActiveRecord::Base
  public :changed_attributes
end

Currently, you cannot assign date or time attributes through delegates_attributes_to.

It raises MultiparameterAssignmentErrors in execute_callstrack_for_multiparameter_attributes because it unable to determine the klass on line 3044.

column_for_attribute needs to be smarter and look up the attribute on the delegate object.

This is with ActiveRecord 2.3.5.

Seems like "loaded_#{association}?" is not defined in Rails 3.1... not sure what the replacement is.