exception resuming SequenceFlow discard - timing of engine save? about bpmn-elements HOT 7 CLOSED

1. I think there is a null guard missing. But the question is why it is needed? I'll start digging.

2.

The ambition is that a resumable state should be available at all times. Though, it has proven hard to implement.

I try to save state at activity-level, i.e. when the activity is started or waiting, etc, and not when the process is in a transition.

Saving state is rather costly, lots of objects to iterate over and asking for state. To top it of, the smqp module uses JSON stringify and parse (my fault).

from bpmn-elements.

Should we consider this resolved with the merge?

from bpmn-elements.

Yes, I'll close this out.

I'm still curious why the discarded flow is sticking around when the engine is saved in activity.wait and whether that's a sign of another issue. The test in #8 demonstrates that scenario if the defensive check is removed.

from bpmn-elements.

True that. Needs further investigation.

from bpmn-elements.

I managed to figure out why this happens - it's the sequence flow pre-flight message that is still in queue waiting for confirmation. Your guard handles that, and I guess it's necessary. Sequence flows has no need to be resumed.

from bpmn-elements.

I have refactored handling of outbound sequence flows so this issue might be resolved.

from bpmn-elements.

No more pre-flight messages able to linger since v2.

from bpmn-elements.