padrinobook / job-vacancy Goto Github PK

A sample app written in Padrino for displaying job offers

Ruby 79.89% JavaScript 1.01% CSS 0.31% HTML 18.80%

job-vacancy's Introduction

This is the application written for my PadrinoBook. There are a lots of commits in there - so feel free to sniff around.

Build

Get the code

git clone https://github.com/padrinobook/job-vacancy

Install dependencies:

cd job-vacancy && bundle

Create all databases:

bundle exec rake ar:create:all

Run migrations:

bundle exec padrino rake ar:migrate -e production && bundle exec padrino rake ar:migrate -e test

Run the tests:

bundle exec rspec

Start the app:

bundle exec padrino s

Specs

Follow the style written under: http://www.betterspecs.org/#describe

License

This software is licensed under the MIT license.

job-vacancy's People

Contributors

Stargazers

Watchers

Forkers

davidsulc aestimo rubycoder matzfan rocknrollmarc scmgopal rx007

job-vacancy's Issues

Not able to login in application

I am created one user in database but not able to login. please help

Get rid of observers - they are a hell for testing.

Try to replace them with whisper https://github.com/krisleech/wisper (other examples can be found here http://stackoverflow.com/questions/15165260/rails-observer-alternatives-for-4-0).

Just a small test

Think about testing spec_helper

Test mails with email-spec

Try it out: https://github.com/email-spec/email-spec

Inspiration for the app

https://www.42jobs.io/rails/jobs

Add the method: :put syntax for creating hidden put messages for users update

Apply better specs

Read through http://betterspecs.org and make the specs better.

Don't send password forget mail if user is not confirmed

It doesn't make sense ...

Add delayed queue for sending mails, because this takes very long in development (and maybe as well in production)

missing test users_controller_spec.rb

it "should redirect if user is correct" do
  user.confirmation = true
  User.should_receive(:find_by_email).and_return(user)
  post "sessions/create", user.attributes

  last_response.should be_redirect
end

is in the book but not in the application ...

When e-mail is confirmed, you are not logged in automatically

Problems testing edit action for user_controller

The controller:

JobVacancy::App.controllers :users do
   before :edit, :update  do
     redirect('/login') unless signed_in?
     @user = User.find_by_id(params[:id])
     redirect('/login') unless current_user?(@user)
   end

  get :edit, :map => '/users/:id/edit' do
    @user = User.find_by_id(params[:id])
    render 'users/edit'
  end

  put :update, :map => '/users/:id' do
    @user = User.find_by_id(params[:id])

    unless @user
      flash[:error] = "User is not registered in our platform."
      render 'users/edit'
    end

    if @user.update_attributes(params[:user])
      flash[:notice] = "You have updated your profile."
      render 'users/edit'
    else
      flash[:error] = "Your profile was not updated."
      render 'users/edit'
    end
  end
end

The spec

require 'spec_helper'

describe "UsersController" do
  describe "GET edit" do
    let(:user) { build(:user) }

    it "render the view for editing a user" do
      User.should_receive(:find_by_id).at_least(:once).with(anything()).and_return(user)

      get "/users/#{user.id}/edit"
      # I come to this point but the last response is not okay but and routing error, as you can see in the output next to this code example

      require 'pry'; binding.pry

      last_response.should be_ok
    end
  end
end

The output of the last_response is:

#<Rack::MockResponse:0xbad94ad0
 @block=nil,
 @body=
  ["<!DOCTYPE html>\n<html>\n<head>\n  <meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\"/>\n  <title>Padr
 @body_string=nil,
 @chunked=false,
 @errors=
  "Padrino::Routing::UnrecognizedException - route mapping for url(:\"users edit\") could not be found!:\n\t/home/wikimatze/.g
 @header=
  {"Content-Type"=>"text/html",
   "Content-Length"=>"233416",
   "Set-Cookie"=>
    "rack.session=BAh7CUkiD3Nlc3Npb25faWQGOgZFVEkiRTQyOTAyNDQ0MGU4MmM3MDgxZWZk%0AZjRjZGQwODFjMWFmOTEwMGFkMWVhZjI5OTk2NjM2MTE5M
 @length=233416,
 @original_headers=
  {"Content-Type"=>"text/html",
   "Content-Length"=>"233416",

I even turned of the the csrf protection in config/apps.rb

Padrino.configure_apps do
  # enable :sessions
#  set :session_secret, '6a3ec199b53b002a3bfaf60ec746b9182c095950b41f182790a81a0e36d96884'
#  set :protection, true
#  set :protect_from_csrf, true
end

It is working if I run the application.