We can add more restrictions (and tests for the restrictions) inside the Password class.
Some restrictions can be:

• Password can't be empty.
• Password must have numbers, letters and one special character.
• Password has to have a minimum length.

I'm trying to get the creationTime date of the PDF from the File attribute. I have been reading online about this and is quite difficult to get the creation date of a file in Linux. The question is, teacher wants us to get the date from the file or just enter the date on the constructor of the PDFDocument class? I think that she wants us to get it from the File but i have only been able to get it in milliseconds.

Some questions about the implementation of UnifiedPlatform:

• processSearcher, selectSS, selectCitizens and selectReports only print the state of the action? We have to implement the state dessign pattern for knowing which state has the application?
• selectCerfiticationReport has to use a byte? We're having primitive obsession!!.
• selectAuthMethod same as selectCertificationReport.
• enterNIF-PINobt how can we break down the two input events? If we're having the two values as parameters!
• enterCred: same as enterNIF-PINObt.

Hey! A great task would be to improve the QuotePeriodsCollection tests. First, we've to discuss the questions on the issue #2 with the teacher and then do a more exhaustive testing on the data structure.
Some tests that I think we need to do are:

1. Add some elements in natural order and check that the collection still in natural order.
2. Add some elements in reverse order (bigger to smaller) and check that the collection still in natural order.
3. What happens with null elements?
4. What happens with objects with same references?
5. What happens with objects with different references but same value? (maybe for this we'll have to see the equals method of QuotePeriod)
6. Tests that if is a new instance of QuotePeriodsCollection, the collection is empty.

Since the QuotePeriodsCollection is a "wrapper" for a TreeSet, the TreeSet document from Java will become very handy for this tests (and for teach the user who does the tests how a TreeSet works).

Please, think about more tests that we can do for this data structure.

I don't think it's clear how does enterCred() works.
Definition:
enterCred(Nif nif, Password passw): emula el uso del formulario donde el usuario
introduce las credenciales que lo acreditan en el sistema Cl@ve permanente.
Se puede desglosar en dos eventos de entrada: uno para el nif y otro para la
contraseña.
Si el usuario ha activado el método reforzado, automáticamente se generará un PIN,
para completar el segundo paso de identificación. Ello implica haber de introducir
ese PIN mediante el método enterPIN(pin) anterior.
Excepciones: las mismas mencionadas anteriormente (NifNotRegisteredException,
AnyMobileRegisteredException, ConnectException) y, adicionalmente,
NotValidCredException, para indicar que las credenciales proporcionadas no son
correctas.

To check if the credentials are correct, checkCred() method will be used.
checkCred() definition:
ckeckCredent(Nif nif, Password passw): retorna un byte que indicará diferentes
situaciones: 0 si el ciudadano no está registrado en el sistema Cl@ve permanente
con esas credenciales; 1 sí lo está y no tiene activado el método reforzado; y 2 si lo
está y utiliza el método reforzado.

My questions are:

1. If the returning value is 0, will enterCred() continue with its execution seting the citizen's document attribute to the corresponding value or it will throw an exception?
2. In case it has to throw an exception, which exception should it throw?

In the forum we were answered the question related to the issue #1, we have to add the following check on the constructor:

Que el nombre de dies no superi la data actual, comptant des de la Date rebuda com a paràmetre.

Create a test file for the following methods:

• EnterNIFPinobt
• enterPIN
• enterCred

Please, think that you will have to create some "mockup" objects that implements SS and CertificationAuthority. Some of this "mockup" objects have to be "error objects". For example, you can create a mockup object that always fail with the connection (raises a ConnectionException) and see how the class should fix or act in this case.

Please @Oscars35 if you have any questions about the implementation, write it here.

Doing the quote period collection class, I realized the following things we've to ask

• Should the method: addQuotePeriod(QuotePeriod quote) throw a NullPointerException if we pass a null reference? (for now it does)
• Should we add duplicated elements? (for now it doesn't)

Please, implement the following methods:

• enterCred method on UnifiedPlatform.
• Testing, which involves:
  • Check enforced method (metodo reforzado)
  • Check simple method (metodo simple)
  • What happens to NotRegistred? (Ask to the forum)?.

Please, for the testing see the oscar branch, since it has all the test interfaces (and has the implementation of Cl@ve Pin Tests, which are similar).

As the teacher explained on the forum, we don't have to check if the instances are null, since they were given to us by the SecuritySocial instance (which we can think that will never give a null reference).
So, we have to:

1. Delete Null checking on LaboralLifeDoc
2. Delete Null checking tests on LaboralLifeDocTest
3. Delete Null checking on MemberAccreditationDoc
4. Delete Null checking tests on MemberAccreditationDocTest.

• enterKeyWords(): no need to do anything
• enterPin(): set the appropiate document depending on the chosen procedure
• enterCred(): Check if reinforced method has been activated.

Tests to be done:

1. Equals with different object (different reference but same data).
2. Equals with same object reference.
3. Not equals.

1. We have to ask about the IOException of the moveDoc method.
2. In the case of having a new constructor, ask about checking if file has already been created.
3. Ask if a file getter is needed

I finished tests for the class PDFDocument. I have just to say that moveDoc test moves the file into another location and then moves the file again to default location just to make sure openDoc test can open the file correctly.

Doing the quote period class, I realized the following things we've to ask

• Can date be null?
• number of days has to be equal or greatter than 1?
• The string format can be something like this?

  Quote{
          initial day: day, 
          number of days: days
   }

Things to be done:

• Create an enumeration with all the certificates that are available.
• Has selectCertificate print all the different certificates?
• Implement selectCertificate on UnifiedPlatform
• Implement the enterPassword method on UnifiedPlatform
• Implement DecryptData on UnifiedPlatform.
• Test the UnifiedPlatform methods injecting the CertificationAuthority and Encryptor and Decryptor instances.

The issue is self explainatory

Ask on the forum if the AccreditationNumber has some length restriction

We have to create MobilePhone class for Citizen because we need it on UnifiedPlatform.

We've to implement PDFDocument + test classes.
In case there's some problem, please @Oscars35 comment it here.

• Can the parameters nif and affiliationNumber from the class MemberAccreditationDoc be null?
• Can the parameters nif and quotaPeriods from the class LaboralLifeDoc be null?

1. On the moveDocTest method, we've to check if the file has actually moved (for now, we're checking only the path instance, not the current file on the operating system).
2. The getPathTest name could be better, getDefaultPathTest is more precise.