p-kaczynski / secretsanta Goto Github PK

The button - and possibly supporting field for tracking - will be used by users to sign off their end of the deal

Will require URI validation, as it's too easy to spoof otherwise.

On user's home page

Currently requirements are presented as errors, they should be visible from the start.

GMail will freeze after 100-150 emails per day, switch to some bulk provider.

Server Error in '/' Application.

Exception of type 'SecretSanta.Services.EmailAbuseProtection+EmailAbuseException' was thrown.

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: SecretSanta.Services.EmailAbuseProtection+EmailAbuseException: Exception of type 'SecretSanta.Services.EmailAbuseProtection+EmailAbuseException' was thrown.

Source Error:

An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.

Stack Trace:

[EmailAbuseException: Exception of type 'SecretSanta.Services.EmailAbuseProtection+EmailAbuseException' was thrown.]
SecretSanta.Services.EmailAbuseProtection.Check() in C:\git\SecretSanta\SecretSanta\Services\EmailAbuseProtection.cs:33
SecretSanta.Services.EmailService.SendConfirmationEmail(SantaUser user) in C:\git\SecretSanta\SecretSanta\Services\EmailService.cs:46
SecretSanta.Controllers.AccountController.ResendConfirmation() in C:\git\SecretSanta\SecretSanta\Controllers\AccountController.cs:131
lambda_method(Closure , ControllerBase , Object[] ) +87
System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary2 parameters) +229 System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary2 parameters) +35
System.Web.Mvc.Async.AsyncControllerActionInvoker.b__39(IAsyncResult asyncResult, ActionInvocation innerInvokeState) +39
System.Web.Mvc.Async.WrappedAsyncResult2.CallEndDelegate(IAsyncResult asyncResult) +71 System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeActionMethod(IAsyncResult asyncResult) +69 System.Web.Mvc.Async.AsyncInvocationWithFilters.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3d() +72 System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385 System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeActionMethodWithFilters(IAsyncResult asyncResult) +69 System.Web.Mvc.Async.<>c__DisplayClass2b.<BeginInvokeAction>b__1c() +38 System.Web.Mvc.Async.<>c__DisplayClass21.<BeginInvokeAction>b__1e(IAsyncResult asyncResult) +185 System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeAction(IAsyncResult asyncResult) +59 System.Web.Mvc.Controller.<BeginExecuteCore>b__1d(IAsyncResult asyncResult, ExecuteCoreState innerState) +29 System.Web.Mvc.Async.WrappedAsyncVoid1.CallEndDelegate(IAsyncResult asyncResult) +67
System.Web.Mvc.Controller.EndExecuteCore(IAsyncResult asyncResult) +52
System.Web.Mvc.Async.WrappedAsyncVoid1.CallEndDelegate(IAsyncResult asyncResult) +36 System.Web.Mvc.Controller.EndExecute(IAsyncResult asyncResult) +38 System.Web.Mvc.MvcHandler.<BeginProcessRequest>b__5(IAsyncResult asyncResult, ProcessRequestState innerState) +43 System.Web.Mvc.Async.WrappedAsyncVoid1.CallEndDelegate(IAsyncResult asyncResult) +67
System.Web.Mvc.MvcHandler.EndProcessRequest(IAsyncResult asyncResult) +38
System.Web.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +656
System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +143

For parcel delivery etc.

Possibly use string.format

Per user feedback the assignment algorithm should allow for setting following options:

• Will not send abroad
• Can send abroad, prefer not
• Can send abroad, no problem

If there are NO situations, where in a single country there is exactly a pair of users, where one will and one won't send gifts abroad, exception will be thrown.

This is due FB Uri being just above password.

A user should have an ability to reset his password via email verification token

As it turns out, it is set to be a POST (makes sense to prevent abuse), but the action was GET, so 404 was rendered.

User -> Assignment
User -> Gifter
User -> Admin

Probably cache is not updated.

The red error window seems to appear whenever model state is not valid, while it should appear only if there are model-level, not field-level, errors to display.

Don't just hide it - it is needed later as the changed value is compared with the one stored. Possibly move email change to separate place completely.