Parsing Twitter Bootstrap. about ucss HOT 11 CLOSED

As far as I can tell, this has to do with the @keyframe syntax, along with its prefixed versions. It seems like it'd be safe to skip on optimizing these, similar to @font-face.

Unfortunately, this appears to be a limitation of CSSOM, which is what ucss uses to parse the css. Here's an issue thread on the CSSOM repo that might point us in a useful direction.

from ucss.

If you're looking for a quick fix, you can (somewhat inefficiently) get ucss to ignore @(-vendorPrefixed-)keyframes by adding this conditional continue in /lib/ucss.js before _shake tries to re_shake around line 33:

if (rule.cssText.indexOf('keyframes') > -1) continue; 

from ucss.

thanks! not looking for a quick fix though. Let's see if your pull gets accepted :)

from ucss.

It turns out that I initially misunderstood the way CSSOM parses keyframes, and as I've come to grasp it a little bit better, I've been able to come up with what I believe to be a more effective way of ignoring them in ucss. I suppose ideally we'd cross-check the name of the keyframes animation with the rest of the css to see if it gets used, but that might wind up adding a whole second pass to the processed output.

from ucss.

Hi guys! Sorry about the late response. I have tons of stuff to do at the moment, but I will hopefully be able to look into the pull request soon. Thanks for the patience!

Ps. Thanks a lot for making a Grunt task for uCSS!

from ucss.

@oyvindeh no worries, I think the uCSS part of the grunt task is more or less complete... (well depending on what you want it to do). I thought of extending its capabilities to also being able to clean away the unused css...

Doing it with regex might be a bit naive though... So, I thought about using CSSOM for that aswell..

from ucss.

I think this should work now :)

from ucss.

@ullmark could you please check if it parses bootstrap now?

from ucss.

@oyvindeh Yep, I'll take a look asap :)

from ucss.

@oyvindeh Yes, it seems to work. It doesn't crash anymore! shipit! ;-)

from ucss.

It's shipped! :)

from ucss.