ovyerus / gfh Goto Github PK

The current name for the binary that gets inserted into gpg.ssh.program as a shim to transform the output from gfh is a bit awkward, and I kinda regret naming it as such originally. I think something like gfh-ssh-shim is probably a better name for it.

When you have a gpg.ssh.allowedSignersFile set in Git and you try to run git log --show-signature, instead of being able to see the validated signatures above each commit, you instead get an error along the lines of this, highlighted in red:

Unable to open allowed keys file "<contents of gpg.ssh.allowedSignersKey has been snipped for the issue>": No such file or directory^M
sig_find_principals: sshsig_find_principal: No such file or directory^M
No principal matched.
thread 'main' panicked at 'git did not provide -f somehow', src/bin/gfh-keygen.rs:16:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It appears that Git calls gpg.ssh.program when using this flag, and since GFH has not been set up to properly handle this scenario it causes this problem. gfh-keygen should handle this situation gracefully, and pass options off to ssh-keygen as normal.

I compiled version 0.0.4 with cargo on my linux system (openSUSE Aeon/Fedora 40) and configured my ~/.config/gfh/keys file correctly (I think):

cat ~/.config/gfh/keys
serial::~/.ssh/id_ed25519_sk_rk_yk-5c
serial::~/.ssh/id_ed25519_sk_rk_yk-5n

When executing gfh, I get:

Error: no matching FIDO key found in the config at /home/$USER/.config/gfh/keys

Stack backtrace:
   0: gfh::main
   1: std::sys_common::backtrace::__rust_begin_short_backtrace
   2: std::rt::lang_start::{{closure}}
   3: std::rt::lang_start_internal
   4: main
   5: __libc_start_call_main
   6: __libc_start_main_impl
   7: _start

gfh -a gives me:

Error: was not able to find any connected FIDO keys

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
   1: gfh::add_key::run
   2: gfh::main
   3: std::sys_common::backtrace::__rust_begin_short_backtrace
   4: std::rt::lang_start::{{closure}}
   5: std::rt::lang_start_internal
   6: main
   7: __libc_start_call_main
   8: __libc_start_main_impl
   9: _start

At first, I had some issues because of missing pcscd (pcsc-lite on rpm distros). I fixed them and got to this. ssh works fine with both of my keys, which is why I believe the error to be in gfh.

Is this description sufficient or should I check some more things on my system?